From: Eli Zaretskii <eliz@gnu.org>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/doc] arm: Expand documentation of XML features
Date: Thu, 23 Feb 2023 13:12:08 +0200 [thread overview]
Message-ID: <834jrcr5yv.fsf@gnu.org> (raw)
In-Reply-To: <20230223095230.1813266-1-luis.machado@arm.com> (message from Luis Machado on Thu, 23 Feb 2023 09:52:30 +0000)
> From: Luis Machado <luis.machado@arm.com>
> CC: <eliz@gnu.org>
> Date: Thu, 23 Feb 2023 09:52:30 +0000
>
> The documentation of the XML features for Arm targets is very brief. I have
> received feedback saying it is quite unclear from the perspective of the
> debugging servers what should be defined in the XML features, how and
> what the outcome is in gdb.
>
> This patch attempts to clarify a bit more what all the possible features are.
Thanks.
> +ARM targets. It must contain the following registers:
> +
> +@itemize @minus
> +@item
> +@samp{r0} through @samp{r12}. They are 32-bit in size and of type
> +@samp{uint32}.
Same comment here as in the previous patch: please say that these are
registers.
> +The description below is for historical purposes only. This feature
> +used to contain the following registers: ^^
Two spaces.
> +@samp{fps}, the status register. It has a size of 32-bit.
^^^^^^
Please lose the dash. I'd say "size of 32 bits." instead.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-02-23 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 9:52 Luis Machado
2023-02-23 11:12 ` Eli Zaretskii [this message]
2023-02-23 13:33 ` Luis Machado
2023-02-24 18:41 ` [PATCH, v2] " Luis Machado
2023-02-24 19:26 ` Eli Zaretskii
2023-03-13 11:32 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jrcr5yv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).