From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 9/9] Use GetThreadDescription on Windows
Date: Wed, 13 Apr 2022 22:33:07 +0300 [thread overview]
Message-ID: <834k2w4w3w.fsf@gnu.org> (raw)
In-Reply-To: <20220413191756.1146768-10-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Wed, 13 Apr 2022 13:17:56 -0600)
> Date: Wed, 13 Apr 2022 13:17:56 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
>
> Windows 10 introduced SetThreadDescription and GetThreadDescription, a
> simpler way to set a thread's name. This changes gdb and gdbserver to
> use this convention when it is available.
Thanks for doing this.
> +const char *
> +windows_thread_info::thread_name ()
> +{
> + if (GetThreadDescription != nullptr)
> + {
> + PWSTR value;
> + HRESULT result = GetThreadDescription (h, &value);
> + if (SUCCEEDED (result))
> + {
> + size_t needed;
> + if (wcstombs_s (&needed, nullptr, 0, value, _TRUNCATE) == 0)
> + {
> + name.reset ((char *) xmalloc (needed));
> + if (wcstombs_s (&needed, name.get (), needed,
> + value, needed - 1) != 0)
> + name.reset ();
> + }
> + LocalFree (value);
> + }
> + }
> +
> + return name.get ();
> +}
AFAIK, wcstombs_s is only available since Vista, so I think we need a
configure-time test for that, and use wcstombs as fallback.
next prev parent reply other threads:[~2022-04-13 19:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 19:17 [PATCH 0/9] Windows thread names Tom Tromey
2022-04-13 19:17 ` [PATCH 1/9] Fix possible Cygwin build problem Tom Tromey
2022-05-21 11:18 ` Jon Turney
2022-05-21 12:31 ` Eli Zaretskii
2022-05-26 17:00 ` Tom Tromey
2022-05-26 19:04 ` Eli Zaretskii
2022-06-02 14:12 ` Jon Turney
2022-06-02 16:04 ` Eli Zaretskii
2022-04-13 19:17 ` [PATCH 2/9] Don't call QUIT in read_string Tom Tromey
2022-04-13 19:17 ` [PATCH 3/9] Rename read_string Tom Tromey
2022-04-13 19:17 ` [PATCH 4/9] Remove the byte order parameter to target_read_string Tom Tromey
2022-04-13 19:17 ` [PATCH 5/9] Move target_read_string to target/target.c Tom Tromey
2022-04-13 19:17 ` [PATCH 6/9] Share handle_ms_vc_exception with gdbserver Tom Tromey
2022-04-13 19:17 ` [PATCH 7/9] Implement thread_name for gdbserver Tom Tromey
2022-04-13 19:17 ` [PATCH 8/9] Set the worker thread name on Windows Tom Tromey
2022-04-13 19:17 ` [PATCH 9/9] Use GetThreadDescription " Tom Tromey
2022-04-13 19:33 ` Eli Zaretskii [this message]
2022-04-14 5:26 ` Eli Zaretskii
2022-04-14 13:17 ` Tom Tromey
2022-04-14 13:51 ` Eli Zaretskii
2022-04-14 18:20 ` Tom Tromey
2022-04-14 18:18 ` Tom Tromey
2022-04-14 13:58 ` [PATCH 0/9] Windows thread names Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834k2w4w3w.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).