public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Jon Turney <jon.turney@dronecode.org.uk>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/9] Fix possible Cygwin build problem
Date: Sat, 21 May 2022 12:18:45 +0100	[thread overview]
Message-ID: <a5624e79-c96a-120d-a568-66868d1671ea@dronecode.org.uk> (raw)
In-Reply-To: <20220413191756.1146768-2-tromey@adacore.com>

On 13/04/2022 20:17, Tom Tromey via Gdb-patches wrote:
> I noticed that nat/windows-nat.c checks __USEWIDE, but nothing sets it
> there -- I forgot to copy over the definition when making this file.
> This patch tries to fix the problem.  I don't have a Cygwin setup, so
> I don't know whether this is sufficient, but it's probably necessary.

Yes, this is necessary, but not sufficient.  I've posted a patch with 
the other needed pieces today.

Otoh, I'm not sure if the !__USEWIDE case has much value anymore, unless 
someone is still building gdb for Windows 9x...

  reply	other threads:[~2022-05-21 11:18 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-13 19:17 [PATCH 0/9] Windows thread names Tom Tromey
2022-04-13 19:17 ` [PATCH 1/9] Fix possible Cygwin build problem Tom Tromey
2022-05-21 11:18   ` Jon Turney [this message]
2022-05-21 12:31     ` Eli Zaretskii
2022-05-26 17:00       ` Tom Tromey
2022-05-26 19:04         ` Eli Zaretskii
2022-06-02 14:12           ` Jon Turney
2022-06-02 16:04             ` Eli Zaretskii
2022-04-13 19:17 ` [PATCH 2/9] Don't call QUIT in read_string Tom Tromey
2022-04-13 19:17 ` [PATCH 3/9] Rename read_string Tom Tromey
2022-04-13 19:17 ` [PATCH 4/9] Remove the byte order parameter to target_read_string Tom Tromey
2022-04-13 19:17 ` [PATCH 5/9] Move target_read_string to target/target.c Tom Tromey
2022-04-13 19:17 ` [PATCH 6/9] Share handle_ms_vc_exception with gdbserver Tom Tromey
2022-04-13 19:17 ` [PATCH 7/9] Implement thread_name for gdbserver Tom Tromey
2022-04-13 19:17 ` [PATCH 8/9] Set the worker thread name on Windows Tom Tromey
2022-04-13 19:17 ` [PATCH 9/9] Use GetThreadDescription " Tom Tromey
2022-04-13 19:33   ` Eli Zaretskii
2022-04-14  5:26     ` Eli Zaretskii
2022-04-14 13:17       ` Tom Tromey
2022-04-14 13:51         ` Eli Zaretskii
2022-04-14 18:20           ` Tom Tromey
2022-04-14 18:18         ` Tom Tromey
2022-04-14 13:58 ` [PATCH 0/9] Windows thread names Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5624e79-c96a-120d-a568-66868d1671ea@dronecode.org.uk \
    --to=jon.turney@dronecode.org.uk \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).