From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv3 3/3] gdb: Track the current frame for each thread
Date: Sat, 26 Sep 2020 09:16:35 +0300 [thread overview]
Message-ID: <834knlrrjw.fsf@gnu.org> (raw)
In-Reply-To: <ceab9eb2457f7b95f60d844c0d44f562e6c16a4d.1601070703.git.andrew.burgess@embecosm.com> (message from Andrew Burgess on Fri, 25 Sep 2020 23:24:09 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Fri, 25 Sep 2020 23:24:09 +0100
>
> +set restore-selected-frame [on|off]
> +show restore-selected-frame
> + This option is off by default. When turned on GDB will record the
^
Comma here, please.
> + currently selected frame in each thread. When switching between
> + threads GDB will attempt to restore the previously selected frame in
^
And here.
> + the thread being switched too. Executing a thread will cause the
> + GDB to discard any previously selected frame (GDB will select the
"the GDB" sounds awkward; please remove "the".
> @item
> -the current stack frame summary for that thread
> +the current stack frame summary for that thread, this is the inner
> +most frame for the thread, see @ref{set restore-selected-frame} to
Here, it is best to use @pxref, like this:
most frame for the thread (@pxref{set restore-selected-frame}) to
> +When switching between threads @value{GDBN} will select the inner most
^
Comma.
> +frame in the thread being switched too, see @ref{set
> +restore-selected-frame} to change this behaviour.
@pxref again.
> +If a thread has been running then when it stops the previously
^ ^
Two commas missing.
> + add_setshow_boolean_cmd ("restore-selected-frame",
> + class_stack, &restore_selected_frame_per_thread,
> + _("\
> +Set whether GDB restores the selected frame when switching threads."), _("\
> +Show whether GDB restores the selected frame when switching threads."), _("\
> +When this option is on GDB will record the currently selected frame for\n\
^
A comma is missing.
Documentation parts are OK with those nits fixed. Thanks.
next prev parent reply other threads:[~2020-09-26 6:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:24 [PATCHv3 0/3] Restore thread and frame patches Andrew Burgess
2020-09-25 22:24 ` [PATCHv3 1/3] gdb: unify two copies of restore_selected_frame Andrew Burgess
2020-09-25 22:24 ` [PATCHv3 2/3] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-09-26 6:09 ` Eli Zaretskii
2020-09-25 22:24 ` [PATCHv3 3/3] gdb: Track the current frame for each thread Andrew Burgess
2020-09-26 6:16 ` Eli Zaretskii [this message]
2020-09-26 8:31 ` Andreas Schwab
2020-09-26 8:54 ` Eli Zaretskii
2020-10-08 9:59 ` [PATCHv3 0/3] Restore thread and frame patches Andrew Burgess
2020-11-06 23:02 ` [PATCHv4 0/2] " Andrew Burgess
2020-11-06 23:02 ` [PATCHv4 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-11-09 15:02 ` Aktemur, Tankut Baris
2020-11-06 23:02 ` [PATCHv4 2/2] gdb: Track the current frame for each thread Andrew Burgess
2020-11-12 11:59 ` [PATCHv5 0/2] Restore thread and frame patches Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 " Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 2/2] gdb: Track the current frame for each thread Andrew Burgess
2020-12-18 8:43 ` Aktemur, Tankut Baris
2021-01-04 15:07 ` Andrew Burgess
2021-01-04 16:08 ` Eli Zaretskii
2021-01-07 10:25 ` [PATCHv6 0/2] Restore thread and frame patches Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 " Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 2/2] gdb: Track the current frame for each thread Andrew Burgess
2021-03-23 11:13 ` [PATCHv8] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2021-03-23 11:43 ` Eli Zaretskii
2020-11-12 11:59 ` [PATCHv5 1/2] " Andrew Burgess
2020-11-12 11:59 ` [PATCHv5 2/2] gdb: Track the current frame for each thread Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834knlrrjw.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).