From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: tankut.baris.aktemur@intel.com, gdb-patches@sourceware.org
Subject: Re: [PATCHv6 2/2] gdb: Track the current frame for each thread
Date: Mon, 04 Jan 2021 18:08:15 +0200 [thread overview]
Message-ID: <83o8i4bs7k.fsf@gnu.org> (raw)
In-Reply-To: <20210104150755.GA2945@embecosm.com> (message from Andrew Burgess on Mon, 4 Jan 2021 15:07:55 +0000)
> Date: Mon, 4 Jan 2021 15:07:55 +0000
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>
> gdb/ChangeLog:
>
> * NEWS: Describe new feature.
> * frame.c (cache_selected_frame_on_thread): New function.
> (select_frame): Call new function.
> * frame.h (get_current_frame): Update comment.
> (get_selected_frame): Update comment.
> * gdbthread.h (class thread_info) <selected_frame_id>: New
> member variable.
> <selected_frame_level>: Likewise.
> (switch_to_thread): Extra parameter.
> * thread.c (switch_to_thread_if_alive): Extra parameter, passed to
> switch_to_thread.
> (scoped_restore_current_thread::restore): Restore the frame either
> from the thread, or from the local object.
> (set_executing_thread): Reset the currently selected frame.
> (restore_selected_frame_per_thread): New file level static variable.
> (show_restore_selected_frame_per_thread): New function.
> (print_thread_info_1): Pass extra parameter to switch_to_thread.
> (switch_to_thread): Take extra parameter, restore the previous
> frame if appropriate.
> (thread_apply_all_command): Pass extra parameter to switch_to_thread.
> (thread_apply_command): Likewise.
> (thread_select): Pass extra parameter to switch_to_thread_if_alive.
> (_initialize_thread): Add new set/show variable.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Threads): Add anchor to 'info threads'. Describe
> the Frame column of 'info threads' more. Describe which frame is
> selected when switching threads, and document the new option for
> restoring the previously selected frame.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.threads/restore-selected-frame.c: New file.
> * gdb.threads/restore-selected-frame.exp: New file.
OK for the documentation parts, thanks.
next prev parent reply other threads:[~2021-01-04 16:08 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 22:24 [PATCHv3 0/3] Restore thread and frame patches Andrew Burgess
2020-09-25 22:24 ` [PATCHv3 1/3] gdb: unify two copies of restore_selected_frame Andrew Burgess
2020-09-25 22:24 ` [PATCHv3 2/3] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-09-26 6:09 ` Eli Zaretskii
2020-09-25 22:24 ` [PATCHv3 3/3] gdb: Track the current frame for each thread Andrew Burgess
2020-09-26 6:16 ` Eli Zaretskii
2020-09-26 8:31 ` Andreas Schwab
2020-09-26 8:54 ` Eli Zaretskii
2020-10-08 9:59 ` [PATCHv3 0/3] Restore thread and frame patches Andrew Burgess
2020-11-06 23:02 ` [PATCHv4 0/2] " Andrew Burgess
2020-11-06 23:02 ` [PATCHv4 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-11-09 15:02 ` Aktemur, Tankut Baris
2020-11-06 23:02 ` [PATCHv4 2/2] gdb: Track the current frame for each thread Andrew Burgess
2020-11-12 11:59 ` [PATCHv5 0/2] Restore thread and frame patches Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 " Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2020-12-10 11:39 ` [PATCHv6 2/2] gdb: Track the current frame for each thread Andrew Burgess
2020-12-18 8:43 ` Aktemur, Tankut Baris
2021-01-04 15:07 ` Andrew Burgess
2021-01-04 16:08 ` Eli Zaretskii [this message]
2021-01-07 10:25 ` [PATCHv6 0/2] Restore thread and frame patches Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 " Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 1/2] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2021-02-12 18:20 ` [PATCHv7 2/2] gdb: Track the current frame for each thread Andrew Burgess
2021-03-23 11:13 ` [PATCHv8] gdb: Restore previously selected thread when switching inferior Andrew Burgess
2021-03-23 11:43 ` Eli Zaretskii
2020-11-12 11:59 ` [PATCHv5 1/2] " Andrew Burgess
2020-11-12 11:59 ` [PATCHv5 2/2] gdb: Track the current frame for each thread Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83o8i4bs7k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).