[PATCH v3 4/4] tracepoint multithread and multiprocess support (doc)

[PATCH v3 4/4] tracepoint multithread and multiprocess support (doc)

[Hui Zhu]

This patch is for the doc.
It add introduce of MultiThreadTracepoint and MultiProcessTracepointTogether.
And add introduce of [:P@var{thread-id}] inside QTDP.

Please help me review it.

Thanks,
Hui

2013-12-31  Hui Zhu  <hui@codesourcery.com>

	* gdb.texinfo (General Query Packets): Men[PATCH v3 4/4] tracepoint multithread and multiprocess support (doc)tion
	MultiThreadTracepoint and MultiProcessTracepointTogether feature.
	(QTDP): Add 'P'.

--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -39655,6 +39655,16 @@ These are the currently defined stub fea
  @tab @samp{-}
  @tab No
  
+@item @samp{MultiThreadTracepoint}
+@tab No
+@tab @samp{-}
+@tab No
+
+@item @samp{MultiProcessTracepointTogether}
+@tab No
+@tab @samp{-}
+@tab No
+
  @end multitable
  
  These are the currently defined stub features, in more detail:
@@ -39828,6 +39838,19 @@ The remote stub understands the @samp{Qb
  @item Qbtrace:bts
  The remote stub understands the @samp{Qbtrace:bts} packet.
  
+@item MultiThreadTracepoint
+@cindex string tracing, in remote protocol
+The remote stub supports creation of tracepoints with multithread
+infomation.
+@xref{Tracepoint Packets}.
+
+@item MultiProcessTracepointTogether
+@cindex string tracing, in remote protocol
+The remote stub supports creation of tracepoints with multiprocess
+infomation and the tracepoints of each inferior will be controlled
+together.
+@xref{Tracepoint Packets}.
+
  @end table
  
  @item qSymbol::
@@ -40355,7 +40378,7 @@ tracepoints (@pxref{Tracepoints}).
  
  @table @samp
  
-@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:X@var{len},@var{bytes}]@r{[}-@r{]}
+@item QTDP:@var{n}:@var{addr}:@var{ena}:@var{step}:@var{pass}[:F@var{flen}][:P@var{thread-id}][:X@var{len},@var{bytes}]@r{[}-@r{]}
  @cindex @samp{QTDP} packet
  Create a new tracepoint, number @var{n}, at @var{addr}.  If @var{ena}
  is @samp{E}, then the tracepoint is enabled; if it is @samp{D}, then
@@ -40363,8 +40386,11 @@ the tracepoint is disabled.  @var{step}
  count, and @var{pass} is its pass count.  If an @samp{F} is present,
  then the tracepoint is to be a fast tracepoint, and the @var{flen} is
  the number of bytes that the target should copy elsewhere to make room
-for the tracepoint.  If an @samp{X} is present, it introduces a
-tracepoint condition, which consists of a hexadecimal length, followed
+for the tracepoint.  If a @samp{P} is present, the thread designator
+@var{thread-id} that has the format and interpretation described in
+@ref{thread-id syntax}, includes the multiprocess and multithread
+infomation of this tracepoint.  If an @samp{X} is present, it introduces
+a tracepoint condition, which consists of a hexadecimal length, followed
  by a comma and hex-encoded bytes, in a manner similar to action
  encodings as described below.  If the trailing @samp{-} is present,
  further @samp{QTDP} packets will follow to specify this tracepoint's

Re: [PATCH v3 4/4] tracepoint multithread and multiprocess support (doc)

[Eli Zaretskii]

> Date: Tue, 31 Dec 2013 11:31:34 +0800
> From: Hui Zhu <hui_zhu@mentor.com>
> CC: Pedro Alves <palves@redhat.com>, <lgustavo@codesourcery.com>, Eli
>  Zaretskii <eliz@gnu.org>
> 
> This patch is for the doc.
> It add introduce of MultiThreadTracepoint and MultiProcessTracepointTogether.
> And add introduce of [:P@var{thread-id}] inside QTDP.

Thanks.

> 2013-12-31  Hui Zhu  <hui@codesourcery.com>
> 
> 	* gdb.texinfo (General Query Packets): Men[PATCH v3 4/4] tracepoint multithread and multiprocess support (doc)tion
> 	MultiThreadTracepoint and MultiProcessTracepointTogether feature.

Bad formatting of the ChangeLog entry.

> +@item MultiThreadTracepoint
> +@cindex string tracing, in remote protocol

This index entry sounds unrelated.  Copy/paste error?

> +The remote stub supports creation of tracepoints with multithread
> +infomation.
   ^^^^^^^^^^
Typo: should be "information"

> +@item MultiProcessTracepointTogether
> +@cindex string tracing, in remote protocol

This index entry also sounds unrelated.  Another copy/paste error?

> +The remote stub supports creation of tracepoints with multiprocess
> +infomation and the tracepoints of each inferior will be controlled
   ^^^^^^^^^^
Another typo.

OK with those gotchas fixed.