From: Eli Zaretskii <eliz@gnu.org>
To: Felix Willgerodt <felix.willgerodt@intel.com>
Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, simark@simark.ca
Subject: Re: [PATCH v10 10/10] btrace: Extend ptwrite event decoding.
Date: Tue, 18 Jul 2023 16:01:24 +0300 [thread overview]
Message-ID: <835y6h74rf.fsf@gnu.org> (raw)
In-Reply-To: <20230718115637.3531-11-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Tue, 18 Jul 2023 13:56:37 +0200)
> Date: Tue, 18 Jul 2023 13:56:37 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
>
> Call the ptwrite filter function whenever a ptwrite event is decoded.
> The returned string is written to the aux_data string table and a
> corresponding auxiliary instruction is appended to the function segment.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> ---
> gdb/NEWS | 7 +
> gdb/btrace.c | 58 +++
> gdb/config.in | 3 +
> gdb/configure | 11 +
> gdb/doc/python.texi | 149 ++++++
> gdb/testsuite/gdb.btrace/i386-ptwrite.S | 550 ++++++++++++++++++++++
> gdb/testsuite/gdb.btrace/ptwrite.c | 39 ++
> gdb/testsuite/gdb.btrace/ptwrite.exp | 202 ++++++++
> gdb/testsuite/gdb.btrace/x86_64-ptwrite.S | 544 +++++++++++++++++++++
> gdb/testsuite/lib/gdb.exp | 72 +++
> gdbsupport/common.m4 | 2 +
> gdbsupport/config.in | 3 +
> gdbsupport/configure | 11 +
> 13 files changed, 1651 insertions(+)
> create mode 100644 gdb/testsuite/gdb.btrace/i386-ptwrite.S
> create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.c
> create mode 100644 gdb/testsuite/gdb.btrace/ptwrite.exp
> create mode 100644 gdb/testsuite/gdb.btrace/x86_64-ptwrite.S
The NEWS part is OK (the rest hasn't changed since v9, AFAIU).
Thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
prev parent reply other threads:[~2023-07-18 13:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 11:56 [PATCH v10 00/10] Extensions for PTWRITE Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 01/10] btrace: Introduce auxiliary instructions Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 02/10] btrace: Enable auxiliary instructions in record instruction-history Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 03/10] btrace: Enable auxiliary instructions in record function-call-history Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 04/10] btrace: Handle stepping and goto for auxiliary instructions Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 05/10] python: Introduce gdb.RecordAuxiliary class Felix Willgerodt
2023-07-25 13:30 ` Metzger, Markus T
2023-08-07 9:08 ` Willgerodt, Felix
2023-08-08 9:37 ` Metzger, Markus T
2023-08-09 9:32 ` Willgerodt, Felix
2023-08-09 10:00 ` Metzger, Markus T
2023-08-30 8:39 ` Willgerodt, Felix
2023-07-18 11:56 ` [PATCH v10 06/10] python: Add clear() to gdb.Record Felix Willgerodt
2023-07-18 13:00 ` Eli Zaretskii
2023-07-18 11:56 ` [PATCH v10 07/10] btrace, gdbserver: Add ptwrite to btrace_config_pt Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 08/10] btrace, linux: Enable ptwrite packets Felix Willgerodt
2023-07-25 13:30 ` Metzger, Markus T
2023-08-07 9:10 ` Willgerodt, Felix
2023-08-08 10:13 ` Metzger, Markus T
2023-08-09 9:31 ` Willgerodt, Felix
2023-08-09 9:48 ` Metzger, Markus T
2023-08-30 8:42 ` Willgerodt, Felix
2023-09-06 14:07 ` Metzger, Markus T
2023-07-18 11:56 ` [PATCH v10 09/10] btrace, python: Enable ptwrite filter registration Felix Willgerodt
2023-07-18 11:56 ` [PATCH v10 10/10] btrace: Extend ptwrite event decoding Felix Willgerodt
2023-07-18 13:01 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y6h74rf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).