public inbox for
 help / color / mirror / Atom feed
From: Eli Zaretskii <>
To: Tom Tromey <>
Subject: Re: [PATCH 3/3] Let Python breakpoints be created silently
Date: Thu, 12 Jan 2023 11:42:24 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (message from Tom Tromey on Wed, 11 Jan 2023 10:31:33 -0700)

> From: Tom Tromey <>
> Cc: Tom Tromey <>, Eli Zaretskii <>
> Date: Wed, 11 Jan 2023 10:31:33 -0700
> >>>>> "Tom" == Tom Tromey via Gdb-patches <> writes:
> Tom> Currently, a breakpoint created from Python will always announce its
> Tom> presence; and in some cases (for example a pending breakpoint), other
> Tom> information will be printed as well.
> Tom> When scripting gdb, it's useful to be able to control the output in
> Tom> cases like this.  I debated whether to simply disable the output
> Tom> entirely, but I thought perhaps some existing code acts as a simple
> Tom> "break"-like command and wants the output.
> Tom> This patch adds a new "announce" flag to gdb.Breakpoint.  Setting this
> Tom> to False will cause gdb to be silent here.
> I think this one still needs a documentation review.

Sorry for missing it.

The patch is okay, with a single gotcha:

> +The optional @var{announce} argument is a boolean that controls
> +whether @var{GDBN} announces the existence of the breakpoint.  The
That should be @value, not @var.

  reply	other threads:[~2023-01-12  9:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 19:18 [PATCH 0/3] Add "announce" flag to Python breakpoint creation Tom Tromey
2022-12-08 19:18 ` [PATCH 1/3] Refactor body of bppy_init Tom Tromey
2022-12-08 19:18 ` [PATCH 2/3] Fix latent bug in Python breakpoint creation Tom Tromey
2023-01-12 17:44   ` Simon Marchi
2022-12-08 19:18 ` [PATCH 3/3] Let Python breakpoints be created silently Tom Tromey
2023-01-11 17:31   ` Tom Tromey
2023-01-12  9:42     ` Eli Zaretskii [this message]
2023-01-12 17:49   ` Simon Marchi
2023-01-13 18:55     ` Tom Tromey
2023-01-13 12:59   ` Pedro Alves
2023-01-13 18:56     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).