Re: [PATCH v2] gdb: add 'maintenance print record-instruction' command

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Bruno Larsen <blarsen@redhat.com>
> Date: Mon, 12 Dec 2022 11:44:17 +0100
> From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
> 
> While chasing some reverse debugging bugs, I found myself wondering what
> was recorded by GDB to undo and redo a certain instruction. This commit
> implements a simple way of printing that information.
> ---
>  gdb/NEWS            |  6 ++++
>  gdb/doc/gdb.texinfo |  8 +++++
>  gdb/record-full.c   | 81 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 95 insertions(+)

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -103,6 +103,12 @@
>  
>  * New commands
>  
> +maintenance print record-instruction [ N ]
> +  Print the recorded information for a given instruction. If N is not given
> +  prints how GDB would undo the last instruction executed. If N is negative,
> +  prints how GDB would undo the N-th previous instruction, and if N is
> +  positive, it prints how GDB will redo the N-th following instruction.

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -40531,6 +40531,14 @@ that symbol is described.  The type chain produced by this command is
>  a recursive definition of the data type as stored in @value{GDBN}'s
>  data structures, including its flags and contained types.
>  
> +@kindex maint print record-instruction
> +@item maint print record-instruction
> +@itemx maint print record-instruction @var{N}
> +@cindex print how GDB recorded a given instruction.  If N is not positive
   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Some editing snafu happened here, it seems?

> +number, it prints the values stored by the inferior before the N-th previous
> +instruction was exectued.  If N is positive, print the values after the N-th
> +following instruction is executed.  If N is not given, 0 is assumed.

In all places where you use "M" (upper-case), you should use "@var{n}"
(with @var and in lower-case).

The gdb.texinfo part is OK with those nits fixed.