Re: [PATCH v2] gdb: add 'maintenance print record-instruction' command

[Pedro Alves <pedro@palves.net>]

On 2022-12-12 10:44 a.m., Bruno Larsen via Gdb-patches wrote:
> While chasing some reverse debugging bugs, I found myself wondering what
> was recorded by GDB to undo and redo a certain instruction. This commit
> implements a simple way of printing that information.

Please include an example of this working in the commit log.

> ---
>  gdb/NEWS            |  6 ++++
>  gdb/doc/gdb.texinfo |  8 +++++
>  gdb/record-full.c   | 81 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 95 insertions(+)
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index c4ccfcc9e32..d6ce6bf86a0 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -103,6 +103,12 @@
>  
>  * New commands
>  
> +maintenance print record-instruction [ N ]
> +  Print the recorded information for a given instruction. If N is not given
> +  prints how GDB would undo the last instruction executed. If N is negative,
> +  prints how GDB would undo the N-th previous instruction, and if N is
> +  positive, it prints how GDB will redo the N-th following instruction.

I noticed missing double space after period in the sentences above.