Re: [PATCH 3/9] gdb/python: new Progspace.executable_filename attribute

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sat, 16 Sep 2023 11:18:04 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> 
> Add a new Progspace.executable_filename attribute that contains the
> path to the executable for this program space, or None if no
> executable is set.
> 
> The path within this attribute will be set by the "exec-file" and/or
> "file" commands.
> 
> Accessing this attribute for an invalid program space will raise an
> exception.
> 
> This new attribute is similar too, but not the same as the existing
> gdb.Progspace.filename attribute.  If I could change the past, I'd
> change the 'filename' attribute to 'symbol_filename', which is what it
> actually represents.  The old attribute will be set by the
> 'symbol-file' command, while the new attribute is set by the
> 'exec-file' command.  Obviously the 'file' command sets both of these
> attributes.
> ---
>  gdb/NEWS                                  |   6 ++
>  gdb/doc/python.texi                       |  15 ++++
>  gdb/python/py-progspace.c                 |  21 +++++
>  gdb/testsuite/gdb.python/py-exec-file.c   |  22 +++++
>  gdb/testsuite/gdb.python/py-exec-file.exp | 100 ++++++++++++++++++++++
>  5 files changed, 164 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.python/py-exec-file.c
>  create mode 100644 gdb/testsuite/gdb.python/py-exec-file.exp

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index f2f5dabb287..93bc9c6a2c0 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -291,6 +291,12 @@ info main
>       Progspace.filename is not None), otherwise, this attribute is
>       itself None.
>  
> +  ** New attribute Progspace.executable_filename.  This attribute
> +     holds a string containing a path set by the "exec-file" or "file"
> +     commands, or None if no executable file is set.  This isn't the
> +     exact string passed by the user to these commands; the path will
> +     have been partially resolved to an absolute path.

GNU Coding Standards frown on using "path" for anything but PATH-style
directory lists.  So please use "file name" here.

> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 03299cc3cf7..206cf6b4e18 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -5059,6 +5059,21 @@
>  access this attribute will raise a @code{RuntimeError} exception.
>  @end defvar
>  
> +@defvar Progspace.executable_filename
> +The file name, as a string, of the executable file in use by this
> +program space.  The executable file is the file that @value{GDBN} will
> +invoke in order to start an inferior when using a native target.  The
> +file name within this attribute is updated by the @kbd{exec-file} and
> +@kbd{file} commands.
> +
> +If no executable is currently set within this @code{Progspace} then
> +this attribute contains @code{None}.
> +
> +If the @code{Progspace} is invalid, i.e.@:, when
> +@code{Progspace.is_valid()} returns @code{False}, then attempting to
> +access this attribute will raise a @code{RuntimeError} exception.
> +@end defvar

This part is OK.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>