From: Tom Tromey <tromey@adacore.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH 9/9] gdb: use reopen_exec_file from reread_symbols
Date: Tue, 19 Sep 2023 08:08:32 -0600 [thread overview]
Message-ID: <87msxi8dcv.fsf@tromey.com> (raw)
In-Reply-To: <beb69bea3ed292317afc7822feaf98e69c5022a6.1694858967.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Sat, 16 Sep 2023 11:18:10 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> + reopen_exec_file ();
This addition could probably use a comment explaining why it is needed.
Andrew> - new_modtime = new_statbuf.st_mtime;
Andrew> + long new_modtime = new_statbuf.st_mtime;
Might as well change this to time_t now.
I don't really understand how reread_symbols interacts with target:
files. It seems like this is just broken.
At AdaCore we carry a patch that changes this code to use bfd_stat.
According to internal notes, this was pushed:
https://sourceware.org/legacy-ml/gdb-patches/2020-01/msg00386.html
... but I don't see it in gdb. Maybe we never resolved the 'stat' issue
in gnulib?
Anyway, the reason I bring this up is that reopen_exec_file calls
bfd_cache_close_all -- but then the loop in reread_symbols, in the
bfd_stat case, will reopen the files (BFD uses fstat). This seems
unfortunate.
I don't think gdb has a very clear idea of when bfd_cache_close_all
ought to be called. It would be good to clear this up. I'm not very
clear on it myself. Maybe it is to avoid ETXTBUSY errors -- in which
case it seems like it should be called just before starting the
inferior. But, ISTR some error on Windows as well, though I don't know
exactly what... so maybe the files need to be guaranteed-closed in other
situations as well.
Tom
next prev parent reply other threads:[~2023-09-19 14:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 10:18 [PATCH 0/9] Add executable_changed event to Python API Andrew Burgess
2023-09-16 10:18 ` [PATCH 1/9] gdb/doc: extend the description for Progspace.filename Andrew Burgess
2023-09-16 10:53 ` Eli Zaretskii
2023-09-16 10:18 ` [PATCH 2/9] gdb/python: new Progspace.symbol_file attribute Andrew Burgess
2023-09-16 10:56 ` Eli Zaretskii
2023-09-16 10:18 ` [PATCH 3/9] gdb/python: new Progspace.executable_filename attribute Andrew Burgess
2023-09-16 10:55 ` Eli Zaretskii
2023-09-16 10:18 ` [PATCH 4/9] gdb: remove one user of the executable changed observer Andrew Burgess
2023-09-16 10:18 ` [PATCH 5/9] gdb: remove final user of the executable_changed observer Andrew Burgess
2023-09-16 10:18 ` [PATCH 6/9] gdb: remove unnecessary notification of " Andrew Burgess
2023-09-16 10:18 ` [PATCH 7/9] gdb: pass more arguments to the " Andrew Burgess
2023-09-16 10:18 ` [PATCH 8/9] gdb/python: make the executable_changed event available from Python Andrew Burgess
2023-09-16 11:03 ` Eli Zaretskii
2023-09-28 14:35 ` Andrew Burgess
2023-09-16 10:18 ` [PATCH 9/9] gdb: use reopen_exec_file from reread_symbols Andrew Burgess
2023-09-19 14:08 ` Tom Tromey [this message]
2023-09-28 15:23 ` Andrew Burgess
2023-09-28 18:15 ` Tom Tromey
2023-09-29 10:17 ` Andrew Burgess
2023-09-29 15:18 ` Eli Zaretskii
2023-10-02 14:16 ` Tom Tromey
2023-09-29 14:42 ` Eli Zaretskii
2023-10-02 14:02 ` Tom Tromey
2023-10-02 16:19 ` Eli Zaretskii
2023-09-19 14:09 ` [PATCH 0/9] Add executable_changed event to Python API Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msxi8dcv.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).