From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches@sourceware.org, pedro@palves.net, tdevries@suse.de,
mliska@suse.cz
Subject: Re: [PATCH v2] [gdb/debuginfod] Ask to cancel further downloads
Date: Thu, 22 Dec 2022 09:01:30 +0200 [thread overview]
Message-ID: <83bknvapmd.fsf@gnu.org> (raw)
In-Reply-To: <20221221214730.112787-1-amerey@redhat.com> (message from Aaron Merey on Wed, 21 Dec 2022 16:47:30 -0500)
> From: Aaron Merey <amerey@redhat.com>
> Cc: gdb-patches@sourceware.org,
> pedro@palves.net,
> tdevries@suse.de,
> mliska@suse.cz,
> Aaron Merey <amerey@redhat.com>
> Date: Wed, 21 Dec 2022 16:47:30 -0500
>
> Hi Eli,
>
> Thanks for the review. I've updated the patch with your suggestions.
>
> On Sat, Dec 17, 2022 at 3:40 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > > +cancel all further downloads before attempting to perform the next query.
> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > I'm not sure I understand the emphasized part. What do you mean by
> > "before attempting"?
>
> Before attempting the next query, there will be a prompt asking whether
> or not to cancel all further downloads in addition to the current download.
> For clarity I've changed the wording: "Pressing @kbd{Ctrl-C} twice during
> downloading will cancel the current download and prompt whether to cancel
> all further downloads."
That SGTM, thanks.
> +@item set debuginfod cancel ask
> +Pressing @kbd{Ctrl-C} twice during downloading will cancel the current
> +download and prompt whether to cancel all further downloads. By default,
Two spaces there, please.
Other than that, the documentation part is OK.
prev parent reply other threads:[~2022-12-22 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-17 0:15 Aaron Merey
2022-12-17 8:23 ` Eli Zaretskii
2022-12-21 21:47 ` Aaron Merey
2022-12-22 7:01 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83bknvapmd.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=mliska@suse.cz \
--cc=pedro@palves.net \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).