public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv2 2/2] gdb/mi: add --no-connection to MI -add-inferior command
Date: Thu, 03 Mar 2022 16:02:52 +0200	[thread overview]
Message-ID: <83bkynjfqr.fsf@gnu.org> (raw)
In-Reply-To: <20220303124439.GF1212730@redhat.com> (message from Andrew Burgess on Thu, 3 Mar 2022 12:44:39 +0000)

> Date: Thu, 3 Mar 2022 12:44:39 +0000
> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org
> 
> > > Date: Wed,  2 Mar 2022 11:57:36 +0000
> > > From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> > > Cc: Andrew Burgess <aburgess@redhat.com>
> > > 
> > > +The command response always has a field, @samp{inferior}, whose value
> > > +is the identifier of the thread group corresponding to the new
> > > +inferior.
> > > +
> > > +An additional section field, @samp{connection}, is optional.  This
> > > +field will only exist if the new inferior has a target connection.  If
> > > +this field exists, then its value will be a tuple containing the
> > > +following fields:
> > 
> > The above two @samp should be @var, since they aren't literal symbols.
> > 
> > OK with that fixed, thanks.
> > 
> > Shouldn't this have a NEWS entry?
> 
> Good point.  The patch below has the @samp -> @var change, plus a NEWS
> entry.

LGTM, thanks.

  reply	other threads:[~2022-03-03 14:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 17:25 [PATCH] Fixing regression in mi " Muhammad Umair Sair
2022-03-02 11:57 ` [PATCHv2 0/2] " Andrew Burgess
2022-03-02 11:57   ` [PATCHv2 1/2] gdb/mi: fix " Andrew Burgess
2022-03-02 11:57   ` [PATCHv2 2/2] gdb/mi: add --no-connection to MI " Andrew Burgess
2022-03-02 20:01     ` Eli Zaretskii
2022-03-03 12:44       ` Andrew Burgess
2022-03-03 14:02         ` Eli Zaretskii [this message]
2022-03-03 14:58         ` Pedro Alves
2022-03-07 19:40           ` Andrew Burgess
2022-03-07 20:37             ` Pedro Alves
2022-03-08 12:55               ` Andrew Burgess
2022-03-08 20:41                 ` Pedro Alves
2022-03-08 12:58               ` [PUSHED 0/2] Fixing regression in mi " Andrew Burgess
2022-03-08 12:58                 ` [PUSHED 1/2] gdb/mi: fix " Andrew Burgess
2022-03-08 12:58                 ` [PUSHED 2/2] gdb/mi: add --no-connection to MI " Andrew Burgess
2022-03-03 14:59   ` [PATCHv2 0/2] Fixing regression in mi " Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83bkynjfqr.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).