From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org, legouguec@adacore.com
Subject: Re: [PATCH v2 3/6] Introduce gdb.interrupt
Date: Mon, 11 Dec 2023 18:30:23 +0200 [thread overview]
Message-ID: <83cyvcvh0g.fsf@gnu.org> (raw)
In-Reply-To: <20231211-dap-cancel-v2-3-db7b52cf0329@adacore.com> (message from Tom Tromey on Mon, 11 Dec 2023 09:02:20 -0700)
> From: Tom Tromey <tromey@adacore.com>
> Date: Mon, 11 Dec 2023 09:02:20 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>,
> Kévin Le Gouguec <legouguec@adacore.com>
>
> DAP cancellation needs a way to interrupt whatever is happening on
> gdb's main thread -- whether that is the inferior, a gdb CLI command,
> or Python code.
>
> This patch adds a new gdb.interrupt() function for this purpose. It
> simply sets the quit flag and lets gdb do the rest.
>
> No tests in this patch -- instead this is tested via the DAP
> cancellation tests.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> Reviewed-By: Kévin Le Gouguec <legouguec@adacore.com>
> ---
> gdb/NEWS | 3 +++
> gdb/doc/python.texi | 11 +++++++++++
> gdb/python/python.c | 19 +++++++++++++++++++
> 3 files changed, 33 insertions(+)
Thanks, the documentation parts are approved.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-12-11 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 16:02 [PATCH v2 0/6] Implement DAP cancellation Tom Tromey
2023-12-11 16:02 ` [PATCH v2 1/6] Clean up handling of DAP not-stopped response Tom Tromey
2023-12-11 16:02 ` [PATCH v2 2/6] Move DAP JSON reader to its own thread Tom Tromey
2023-12-11 16:02 ` [PATCH v2 3/6] Introduce gdb.interrupt Tom Tromey
2023-12-11 16:30 ` Eli Zaretskii [this message]
2023-12-11 16:02 ` [PATCH v2 4/6] Rename a couple of DAP procs in the testsuite Tom Tromey
2023-12-11 16:02 ` [PATCH v2 5/6] Catch KeyboardInterrupt in send_gdb_with_response Tom Tromey
2023-12-11 17:53 ` Kévin Le Gouguec
2023-12-11 16:02 ` [PATCH v2 6/6] Implement DAP cancellation Tom Tromey
2023-12-11 18:53 ` [PATCH v2 0/6] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83cyvcvh0g.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=legouguec@adacore.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).