Re: [PATCH v3 3/3] Support template lookups in strncmp_iw_with_mode

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu,  9 Dec 2021 11:17:50 -0800
> From: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
> 
>  gdb/NEWS                                    |   4 +
>  gdb/cp-support.c                            |   8 +-
>  gdb/doc/gdb.texinfo                         |  46 +++
>  gdb/testsuite/gdb.cp/templates.cc           |  47 +++
>  gdb/testsuite/gdb.cp/templates.exp          |  67 +++
>  gdb/testsuite/gdb.linespec/cpcompletion.exp | 437 +++++++++++++++++++-
>  gdb/testsuite/gdb.linespec/cpls-ops.exp     |  53 ++-
>  gdb/testsuite/gdb.linespec/cpls.cc          | 110 ++++-
>  gdb/utils.c                                 |  82 +++-
>  gdb/utils.h                                 |   7 +-
>  10 files changed, 821 insertions(+), 40 deletions(-)

Thanks.

I find the documentation of this feature hard to understand.  I didn't
understand what this does until I've read all of the new text,
including the examples, twice.

I think the documentation could be a lot more self-explanatory if the
part about ignoring the template parameters were mentioned much
earlier.

> +* C++ developers may now ignore template parameter lists when specifying
> +  locations, e.g., while setting breakpoints.  This is analogous to how
> +  completion and symbol lookup handle overloaded functions or ABI tags.

This could be more clear if it described the GDB behavior, not what
GDB users can do due to changes in the GDB behavior.