public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb] Fix maint print symbols/psymbols help text
Date: Mon, 14 Aug 2023 15:14:12 +0300	[thread overview]
Message-ID: <83edk5bz3f.fsf@gnu.org> (raw)
In-Reply-To: <20230814085340.4066-1-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Mon, 14 Aug 2023 10:53:40 +0200)

> Date: Mon, 14 Aug 2023 10:53:40 +0200
> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/psymtab.c b/gdb/psymtab.c
> index 64b67078641..bdae9db9676 100644
> --- a/gdb/psymtab.c
> +++ b/gdb/psymtab.c
> @@ -1687,7 +1687,7 @@ Entries in the partial symbol table are dumped to file OUTFILE,\n\
>  or the terminal if OUTFILE is unspecified.\n\
>  If ADDRESS is provided, dump only the file for that address.\n\
>  If SOURCE is provided, dump only that file's symbols.\n\
> -If OBJFILE is provided, dump only that file's minimal symbols."),
> +If OBJFILE is provided, dump only that object file's symbols."),
>  	   &maintenanceprintlist);
>  
>    add_cmd ("psymtabs", class_maintenance, maintenance_info_psymtabs, _("\
> diff --git a/gdb/symmisc.c b/gdb/symmisc.c
> index a65552aa2d2..5b8a82e5137 100644
> --- a/gdb/symmisc.c
> +++ b/gdb/symmisc.c
> @@ -1052,7 +1052,7 @@ Entries in the full symbol table are dumped to file OUTFILE,\n\
>  or the terminal if OUTFILE is unspecified.\n\
>  If ADDRESS is provided, dump only the file for that address.\n\
>  If SOURCE is provided, dump only that file's symbols.\n\
> -If OBJFILE is provided, dump only that file's minimal symbols."),
> +If OBJFILE is provided, dump only that object file's symbols."),
>  	   &maintenanceprintlist);
>  
>    add_cmd ("msymbols", class_maintenance, maintenance_print_msymbols, _("\

Thanks, this LGTM, but shouldn't the "ADDRESS" line be reworded like
below?

  If ADDRESS is provided, dump only the symbols for that address.

If that's not the intent, then can someone please explain the meaning
of "the file for that address"?

  reply	other threads:[~2023-08-14 12:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-14  8:53 Tom de Vries
2023-08-14 12:14 ` Eli Zaretskii [this message]
2023-08-14 12:48   ` Tom de Vries
2023-08-14 13:39     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83edk5bz3f.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).