From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/6] gdb/python: Add gdb.Inferior.__dict__ attribute
Date: Fri, 05 Jan 2024 15:33:11 +0200 [thread overview]
Message-ID: <83il47vrag.fsf@gnu.org> (raw)
In-Reply-To: <6eb215cd5252a70326d1ec5bd9c7d96e9a6d20e5.1704455158.git.aburgess@redhat.com> (message from Andrew Burgess on Fri, 5 Jan 2024 11:48:34 +0000)
> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Fri, 5 Jan 2024 11:48:34 +0000
>
> The gdb.Objfile, gdb.Progspace, and gdb.Type Python types already have
> a __dict__ attribute, which allows users to create user defined
> attributes within the objects. This is useful if the user wants to
> cache information within an object.
>
> This commit adds the same functionality to the gdb.Inferior type.
>
> After this commit there is a new gdb.Inferior.__dict__ attribute,
> which is a dictionary. A user can, for example, do this:
>
> (gdb) pi
> >>> i = gdb.selected_inferior()
> >>> i._user_attribute = 123
> >>> i._user_attribute
> 123
> >>>
>
> There's a new test included.
> ---
> gdb/NEWS | 4 +++
> gdb/doc/python.texi | 32 ++++++++++++++++++++++++
> gdb/python/py-inferior.c | 13 +++++++++-
> gdb/testsuite/gdb.python/py-inferior.exp | 19 ++++++++++++++
> 4 files changed, 67 insertions(+), 1 deletion(-)
Is this patch different from the 6/6 one? if so, how?
In any case, my comments are the same as in 6/6, thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2024-01-05 13:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 11:48 [PATCH 0/6] Python __repr__() methods and new __dict__ attributes Andrew Burgess
2024-01-05 11:48 ` [PATCH 1/6] gdb/python: hoist common invalid object repr code into py-utils.c Andrew Burgess
2024-01-09 19:19 ` Tom Tromey
2024-01-05 11:48 ` [PATCH 2/6] gdb/python: add gdb.InferiorThread.__repr__() method Andrew Burgess
2024-01-05 11:48 ` [PATCH 3/6] gdb/python: add gdb.Frame.__repr__() method Andrew Burgess
2024-01-05 11:48 ` [PATCH 4/6] gdb/python: remove users ability to create gdb.Progspace objects Andrew Burgess
2024-01-05 13:27 ` Eli Zaretskii
2024-01-05 11:48 ` [PATCH 5/6] gdb/python: Add gdb.Inferior.__dict__ attribute Andrew Burgess
2024-01-05 13:33 ` Eli Zaretskii [this message]
2024-01-09 20:05 ` Tom Tromey
2024-01-05 11:48 ` [PATCH 6/6] gdb/python: Add gdb.InferiorThread.__dict__ attribute Andrew Burgess
2024-01-05 13:31 ` Eli Zaretskii
2024-01-09 20:11 ` Tom Tromey
2024-01-10 10:38 ` Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 0/8] Python __repr__() methods and new __dict__ attributes Andrew Burgess
2024-01-09 17:32 ` [PATCH] gdb/python: New InferiorThread.ptid_string attribute Andrew Burgess
2024-01-09 18:50 ` Eli Zaretskii
2024-01-09 19:10 ` Tom Tromey
2024-01-12 9:39 ` [PUSHED] " Andrew Burgess
2024-01-10 15:54 ` [PATCH] " Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 1/8] gdb/python: hoist common invalid object repr code into py-utils.c Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 2/8] gdb/python: add gdb.InferiorThread.__repr__() method Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 3/8] gdb/python: add gdb.Frame.__repr__() method Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 4/8] gdb/python: remove users ability to create gdb.Progspace objects Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 5/8] gdb/python: Add gdb.Inferior.__dict__ attribute Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 6/8] gdb/python: Add gdb.InferiorThread.__dict__ attribute Andrew Burgess
2024-01-10 15:54 ` [PATCHv2 7/8] gdb/doc: add some notes on selecting suitable attribute names Andrew Burgess
2024-01-10 16:35 ` Eli Zaretskii
2024-01-11 10:48 ` Andrew Burgess
2024-01-11 10:56 ` Eli Zaretskii
2024-01-10 15:54 ` [PATCHv2 8/8] gdb/doc: update examples in gdb.Progspace and gdb.Objfile docs Andrew Burgess
2024-01-10 16:36 ` Eli Zaretskii
2024-01-10 18:08 ` [PATCHv2 0/8] Python __repr__() methods and new __dict__ attributes Tom Tromey
2024-01-12 13:44 ` Andrew Burgess
2024-01-12 14:57 ` Tom de Vries
2024-01-12 16:20 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83il47vrag.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).