Re: [PATCH 6/6] gdb/python: Add gdb.InferiorThread.__dict__ attribute

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Fri,  5 Jan 2024 11:48:35 +0000
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 500d5ab7160..c4862a8beb6 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -96,6 +96,10 @@ show remote thread-options-packet
>       these will be stored in the object's new Inferior.__dict__
>       attribute.
>  
> +  ** User defined attributes can be added to a gdb.InferiorThread
> +     object, these will be stored in the object's new
> +     InferiorThread.__dict__ attribute.

This part is OK.

> +@smallexample
> +(gdb) python
> +import datetime
> +
> +def thread_stopped(event):
> +    if event.inferior_thread is not None:
> +        thread = event.inferior_thread
> +    else:
> +        thread = gdb.selected_thread()
> +    thread._last_stop_time = datetime.datetime.today()
> +
> +gdb.events.stop.connect(thread_stopped)
> +(gdb) file /tmp/hello
> +Reading symbols from /tmp/hello...
> +(gdb) start
> +Temporary breakpoint 1 at 0x401198: file /tmp/hello.c, line 18.
> +Starting program: /tmp/hello
> +
> +Temporary breakpoint 1, main () at /tmp/hello.c:18
> +18	  printf ("Hello World\n");
> +(gdb) python print(gdb.selected_thread()._last_stop_time)
> +2024-01-04 14:48:41.347036
> +@end smallexample

When you have an @example that consists of more than just a couple of
lines, and has empty lines in it, it is a good idea to divide it into
separate parts using @group..@end group.  This will make sure that in
the printed manual such @group's will never be split across pages,
thus making it easier to read the example.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>