public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, tdevries@suse.de
Subject: Re: [PATCH 3/3] [gdb/tui] Add tui border-kind active-ascii
Date: Fri, 15 Dec 2023 22:04:43 +0200	[thread overview]
Message-ID: <83il4znsf8.fsf@gnu.org> (raw)
In-Reply-To: <87jzpf5jpt.fsf@tromey.com> (message from Tom Tromey on Fri, 15 Dec 2023 12:50:06 -0700)

> From: Tom Tromey <tom@tromey.com>
> Cc: Tom de Vries <tdevries@suse.de>,  Tom Tromey <tom@tromey.com>
> Date: Fri, 15 Dec 2023 12:50:06 -0700
> 
> >>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> Add a new border-kind active-ascii, that's like border-kind ascii for inactive
> Tom> windows but uses '+' as hline and vline (instead of '-' and '|') for an active
> Tom> window.
> 
> I'm fine with this if you still want to do it.
> Personally I'm more interested in whether we can make the TUI look
> "sleek and modern" but this sort of thing is fine too.
> 
> It may still need a doc review?  Not sure.

The documentation part is basically trivial.  It's okay by me.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

      reply	other threads:[~2023-12-15 20:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 14:10 [PATCH 0/3] " Tom de Vries
2023-05-08 14:10 ` [PATCH 1/3] [gdb/tui] Make tui_update_variables more readable Tom de Vries
2023-12-15 19:48   ` Tom Tromey
2023-05-08 14:10 ` [PATCH 2/3] [gdb/tui] Fix buglet in set_border_kind_item Tom de Vries
2023-05-22 14:47   ` [pushed] [gdb/tui] Fix buglet in tui_update_variables Tom de Vries
2023-05-08 14:10 ` [PATCH 3/3] [gdb/tui] Add tui border-kind active-ascii Tom de Vries
2023-12-15 19:50   ` Tom Tromey
2023-12-15 20:04     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83il4znsf8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).