From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Style URLs in GDB output
Date: Thu, 10 Mar 2022 08:38:00 +0200 [thread overview]
Message-ID: <83ilsme2if.fsf@gnu.org> (raw)
In-Reply-To: <20220310003152.80655-1-tom@tromey.com> (message from Tom Tromey on Wed, 9 Mar 2022 17:31:52 -0700)
> From: Tom Tromey <tom@tromey.com>
> Date: Wed, 9 Mar 2022 17:31:52 -0700
> Cc: Tom Tromey <tom@tromey.com>
>
> I noticed that GDB will display URLs in a few spots. This changes
> them to be styled. Originally I thought I'd introduce a new "url"
> style, but there aren't many places to use this, so I just reused
> filename styling instead. This patch also changes the debuginfod URL
> list to be printed one URL per line. I think this is probably a bit
> easier to read.
File-name styling for URLs is fine, IMO. We don't need to invent a
new style.
> gdb/debuginfod-support.c | 25 +++++++++++++++++++++----
> gdb/doc/gdb.texinfo | 2 +-
> gdb/testsuite/gdb.base/style.exp | 5 +++--
> gdb/top.c | 10 +++++++---
> 4 files changed, 32 insertions(+), 10 deletions(-)
The documentation part of the patch is OK, thanks.
next prev parent reply other threads:[~2022-03-10 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 0:31 Tom Tromey
2022-03-10 6:38 ` Eli Zaretskii [this message]
2022-03-10 7:15 ` Aktemur, Tankut Baris
2022-03-15 21:19 ` Tom Tromey
2022-03-31 23:56 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilsme2if.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).