public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Bruno Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2 3/4] gdb/cli: add '.' as an argument for 'list' command
Date: Tue, 20 Jun 2023 19:22:59 +0300	[thread overview]
Message-ID: <83jzvy5cik.fsf@gnu.org> (raw)
In-Reply-To: <20230620155259.2476415-4-blarsen@redhat.com> (message from Bruno Larsen on Tue, 20 Jun 2023 17:52:59 +0200)

> From: Bruno Larsen <blarsen@redhat.com>
> Cc: eliz@gnu.org,
> 	Bruno Larsen <blarsen@redhat.com>
> Date: Tue, 20 Jun 2023 17:52:59 +0200
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index c5519e320e6..aa14e64e51c 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -85,6 +85,10 @@
>    is either the last solitary line printed (if there was one) or around
>    the main function.
>  
> +* The 'list' command now accepts '.' as an argument, which tells GDB to
> +  print the location where the inferior is stopped.  If the inferior hasn't
> +  started yet, the command will error out.

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -9151,8 +9151,14 @@ it prints the lines around the function @code{main}.
>  
>  @item list -
>  Print lines just before the lines last printed.
> +
> +@item list .
> +Print the lines surrounding the location that is currently being
> +examined by the user (that is, the lines around the last solitary
> +line printed).

The text in NEWS mentioned the place where the inferior is stopped,
which I think is an important information.  This text omits this for
some reason.  How about adding it here?

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

  reply	other threads:[~2023-06-20 16:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-20 15:52 [PATCH v2 0/4] Small changes to "list" command Bruno Larsen
2023-06-20 15:52 ` [PATCH v2 1/4] gdb/cli: Factor out code to list lines for the first time Bruno Larsen
2023-06-20 15:52 ` [PATCH v2 2/4] gdb/cli: Improve UX when using list with no args Bruno Larsen
2023-06-20 16:19   ` Eli Zaretskii
2023-06-20 15:52 ` [PATCH v2 3/4] gdb/cli: add '.' as an argument for 'list' command Bruno Larsen
2023-06-20 16:22   ` Eli Zaretskii [this message]
2023-06-20 15:53 ` [PATCH v2 4/4] gdb/doc: document '+' " Bruno Larsen
2023-06-20 16:20   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83jzvy5cik.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).