Re: [PATCH v2] [gdb/infcmd]: Add next-expression command

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Simon Farre <simon.farre.cx@gmail.com>
> Date: Thu, 18 May 2023 16:45:52 +0200
> From: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
> 
>  gdb/NEWS               |  7 ++++
>  gdb/buildsym-legacy.c  |  4 +-
>  gdb/buildsym-legacy.h  |  2 +-
>  gdb/buildsym.c         |  3 +-
>  gdb/buildsym.h         |  4 +-
>  gdb/coffread.c         |  4 +-
>  gdb/dbxread.c          |  6 +--
>  gdb/doc/gdb.texinfo    | 16 +++++++-
>  gdb/doc/python.texi    |  6 +++
>  gdb/dwarf2/read.c      | 32 ++++++++++-----
>  gdb/gdbthread.h        |  2 +
>  gdb/infcmd.c           | 91 +++++++++++++++++++++++++++++++++++-------
>  gdb/infrun.c           |  8 ++++
>  gdb/mdebugread.c       |  2 +-
>  gdb/python/py-symtab.c | 29 ++++++++++----
>  gdb/stack.c            |  7 ++++
>  gdb/symtab.c           |  1 +
>  gdb/symtab.h           | 22 ++++++++++
>  18 files changed, 201 insertions(+), 45 deletions(-)

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index b82114d80b0..38c6f54564b 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,13 @@
>  
>  *** Changes since GDB 13
>  
> +* New commmand "next-expression" ("ne") that steps by expression or statement
> +  on a single source line if debug information is available.
> +
> +* New column attribute of Python type Symtab_and_line to reflect the added
> +  column field on "linetable_entry". Describes what column on the source line
                                      ^^
Two spaces there.

> +  that is being executed. Columns are byte-level coordinates on a source line.
                           ^^
And there.

> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -5899,6 +5899,12 @@ Indicates the current line number for this object.  This
>  attribute is not writable.
>  @end defvar
>  
> +@defvar Symtab_and_line.column
> +Indicates the current column number for this object.  This
> +attribute is not writeable.  A source-line column is it's byte position
                                                        ^^^^
"its', not "it's".

Reviewed-By: Eli Zaretskii <eliz@gnu.org>