Re: [PATCH 4/4] Reimplement array concatenation for Ada and D

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 15 Mar 2022 07:25:00 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> This started as a patch to implement string concatenation for Ada.
> However, while working on this, I looked at how this code could
> possibly be called.  It turns out there are only two users of
> concat_operation: Ada and D.  So, in addition to implementing this for
> Ada, this patch rewrites value_concat, removing the odd "concatenate
> or repeat" semantics, which were completely unused.  As Ada and D both
> seem to represent strings using TYPE_CODE_ARRAY, this removes the
> TYPE_CODE_STRING code from there as well.
> ---
>  gdb/ada-exp.h                          |  15 +++
>  gdb/ada-exp.y                          |   2 +-
>  gdb/ada-lang.c                         |  58 ++++++++-
>  gdb/doc/gdb.texinfo                    |   5 +-
>  gdb/testsuite/gdb.ada/widewide.exp     |  12 ++
>  gdb/testsuite/gdb.dlang/expression.exp |   4 +
>  gdb/valarith.c                         | 169 ++++++-------------------
>  7 files changed, 131 insertions(+), 134 deletions(-)

OK for the documentation part.

Thanks.