Re: [PATCH v1] gdb/dap - dataBreakpointInfo & setDataBreakpoints

[Eli Zaretskii <eliz@gnu.org>]

> Cc: tom@tromey.com,
> 	Simon Farre <simon.farre.cx@gmail.com>
> Date: Wed, 14 Jun 2023 12:33:27 +0200
> From: Simon Farre via Gdb-patches <gdb-patches@sourceware.org>
> 
> This is v1 of the implementation of these two requests.

I didn't (and cannot) review this in a useful way, but my eye caught a
few nits:

> -    if bp.locations:
> +    if bp.location is not None:
>          # Just choose the first location, because DAP doesn't allow
>          # multiple locations.  See
>          # https://github.com/microsoft/debug-adapter-protocol/issues/13
> +        # FIXME this does not matter; GDB can translate it's understanding
                                                           ^^^^
"its"

> +    # frameId does not have an effect when var ref is not none,
                                                             ^^^^
"None", capitalized?

> +    # however, frameId really never has an effect. An issue has been filed:
                                                    ^^
Two spaces there.

> +    # We've resolved the "path" for the variable using varrefs. Construct it
                                                                 ^^
And there.

> +    # Delete wps that are not found in `breakpoints` request
                                          ^^^^^^^^^^^^^
Are we okay with MD-style markup?

Thanks.