From: Eli Zaretskii <eliz@gnu.org>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/tui] Add set style tui-status-window
Date: Mon, 22 May 2023 16:47:01 +0300 [thread overview]
Message-ID: <83sfbopjfu.fsf@gnu.org> (raw)
In-Reply-To: <20230522131545.12291-3-tdevries@suse.de> (message from Tom de Vries via Gdb-patches on Mon, 22 May 2023 15:15:40 +0200)
> Cc: Tom Tromey <tom@tromey.com>
> Date: Mon, 22 May 2023 15:15:40 +0200
> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
>
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -27300,6 +27300,13 @@ general styling to @value{GDBN}. @xref{TUI Configuration}.
> Control the styling of the active TUI border; that is, the TUI window
> that has the focus.
>
> +@item tui-status-window
> +Control the styling of the TUI status window. Note that, unlike other
> +styling options, the tui-border has a mode rather than an intensity.
> +The values for mode are the same as for @ref{set tui border-mode} and
> +@ref{set tui active-border-mode}. By default, this style's mode is
This use of @ref is not recommended. It looks better in the HTML
version of the manual, but in Info and in PDF it looks like a typo or
editing error. I suggest to use @pxref instead, like this:
The values for mode are the same as for tui border-mode (@pxref{set
tui border-mode}) and tui active-border-mode.
It might look less elegant in HTML, but much better in other formats.
> +standout, and the foreground and background colors are none.
^^^^
"@code{none}", perhaps?
> +@anchor{set tui border-mode}
> @item set tui border-mode @var{mode}
> @kindex set tui border-mode
> +@anchor{set tui active-border-mode}
> @itemx set tui active-border-mode @var{mode}
> @kindex set tui active-border-mode
If you go with my suggestion above about @pxref, you don't need the
second one of these @anchor's.
Thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-05-22 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 13:15 [PATCH 0/6] [gdb/tui] Introduce ansi-for-tui Tom de Vries
2023-05-22 13:15 ` [PATCH 1/6] [gdb/testsuite] Use TERM=dummy in gdb.tui/tuiterm.exp Tom de Vries
2023-05-22 13:15 ` [PATCH] [gdb/tui] Add set style tui-status-window Tom de Vries
2023-05-22 13:47 ` Eli Zaretskii [this message]
2023-05-22 14:22 ` Tom de Vries
2023-05-22 15:50 ` Eli Zaretskii
2023-05-22 13:15 ` [PATCH 2/6] [gdb/testsuite] Factor out Term::_wrap_cursor Tom de Vries
2023-05-22 13:15 ` [PATCH 3/6] [gdb/contrib] Add ansi-for-tui.sh Tom de Vries
2023-05-22 13:15 ` [PATCH 4/6] [gdb/testsuite] Make ansi-for-tui available in with_tuiterm Tom de Vries
2023-05-22 13:15 ` [PATCH 5/6] [gdb/testsuite] Implement the newline glitch in tuiterm Tom de Vries
2023-05-22 13:15 ` [PATCH 6/6] [gdb/testsuite] Use ansi-for-tui " Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfbopjfu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).