From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: split array and string limiting options
Date: Thu, 07 Oct 2021 16:38:45 +0300 [thread overview]
Message-ID: <83sfxdymxm.fsf@gnu.org> (raw)
In-Reply-To: <20211007131451.849029-1-andrew.burgess@embecosm.com> (message from Andrew Burgess on Thu, 7 Oct 2021 14:14:51 +0100)
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Date: Thu, 7 Oct 2021 14:14:51 +0100
>
> gdb/NEWS | 18 ++++++
> gdb/ada-valprint.c | 4 +-
> gdb/c-lang.c | 2 +-
> gdb/c-valprint.c | 4 +-
> gdb/doc/gdb.texinfo | 36 +++++++++--
> gdb/language.h | 2 +-
> gdb/m2-lang.c | 2 +-
> gdb/m2-valprint.c | 2 +-
> gdb/p-lang.c | 2 +-
> gdb/p-valprint.c | 2 +-
> gdb/printcmd.c | 4 +-
> gdb/python/py-value.c | 6 +-
> gdb/testsuite/gdb.ada/str_chars.exp | 64 +++++++++++++++++++
> gdb/testsuite/gdb.ada/str_chars/foo.adb | 26 ++++++++
> gdb/testsuite/gdb.base/default.exp | 4 +-
> gdb/testsuite/gdb.base/examine-backward.exp | 6 ++
> gdb/testsuite/gdb.base/options.exp | 1 +
> gdb/testsuite/gdb.base/printcmds.exp | 28 ++++----
> gdb/testsuite/gdb.base/wchar.exp | 6 +-
> gdb/testsuite/gdb.base/with.exp | 2 +-
> gdb/testsuite/gdb.guile/scm-pretty-print.exp | 12 ++--
> gdb/testsuite/gdb.pascal/str-chars.exp | 48 ++++++++++++++
> gdb/testsuite/gdb.pascal/str-chars.pas | 28 ++++++++
> gdb/testsuite/gdb.python/py-format-string.exp | 13 ++--
> gdb/testsuite/gdb.python/py-prettyprint.exp | 8 ++-
> gdb/testsuite/lib/gdb.exp | 2 +-
> gdb/tracepoint.c | 4 +-
> gdb/valprint.c | 51 +++++++++++----
> gdb/valprint.h | 3 +
> 29 files changed, 321 insertions(+), 69 deletions(-)
> create mode 100644 gdb/testsuite/gdb.ada/str_chars.exp
> create mode 100644 gdb/testsuite/gdb.ada/str_chars/foo.adb
> create mode 100644 gdb/testsuite/gdb.pascal/str-chars.exp
> create mode 100644 gdb/testsuite/gdb.pascal/str-chars.pas
The documentation parts are okay, with one comment: you say
"characters", but the code actually limits the number of bytes, not
characters, right?
Thanks.
next prev parent reply other threads:[~2021-10-07 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 13:14 Andrew Burgess
2021-10-07 13:38 ` Eli Zaretskii [this message]
2021-11-02 10:04 ` [PING][PATCH] " Maciej W. Rozycki
2021-11-09 16:45 ` [PING^2][PATCH] " Maciej W. Rozycki
2021-11-16 12:40 ` [PING^3][PATCH] " Maciej W. Rozycki
2021-11-23 21:37 ` [PING^4][PATCH] " Maciej W. Rozycki
2021-11-30 13:15 ` [PING^5][PATCH] " Maciej W. Rozycki
2021-12-08 23:19 ` [PING^6][PATCH] " Maciej W. Rozycki
2021-12-09 3:01 ` [PATCH] " Simon Marchi
2021-12-14 16:35 ` Maciej W. Rozycki
2022-01-14 19:52 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83sfxdymxm.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).