From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Move some Windows operations to worker thread
Date: Wed, 03 Aug 2022 22:16:21 +0300 [thread overview]
Message-ID: <83v8r93zp6.fsf@gnu.org> (raw)
In-Reply-To: <87les5go5f.fsf@tromey.com> (message from Tom Tromey on Wed, 03 Aug 2022 12:47:24 -0600)
> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
> Date: Wed, 03 Aug 2022 12:47:24 -0600
>
> >> + HANDLE bg_thread = CreateThread (nullptr, 0, fn, this, 0, nullptr);
>
> Eli> That zero in the 2nd argument of CreateThread means the worker thread
> Eli> will get the same stack size as the value recorded in the GDB
> Eli> executable file's header, which is 12MB according to my reading of
> Eli> gdb/Makefile, at least in my build? That's unlikely to be required
> Eli> for this thread, so I suggest to specify a non-zero value there
> Eli> instead. I guess 64KB should be enough?
>
> I changed it to `64 * 1024` and re-tested, and this worked ok.
Thanks.
next prev parent reply other threads:[~2022-08-03 19:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 13:08 [PATCH 0/2] Implement target async for Windows Tom Tromey
2022-08-03 13:08 ` [PATCH 1/2] Move some Windows operations to worker thread Tom Tromey
2022-08-03 13:33 ` Eli Zaretskii
2022-08-03 18:47 ` Tom Tromey
2022-08-03 19:16 ` Eli Zaretskii [this message]
2022-08-03 13:08 ` [PATCH 2/2] Implement target async for Windows Tom Tromey
2022-11-04 14:28 ` Jon Turney
2022-11-08 18:38 ` Tom Tromey
2022-11-13 14:45 ` Jon Turney
2022-11-04 14:59 ` Jon Turney
2022-11-08 18:52 ` Tom Tromey
2022-11-17 14:33 ` Jon Turney
2022-11-17 18:38 ` Tom Tromey
2022-11-17 18:43 ` Tom Tromey
2022-08-03 13:34 ` [PATCH 0/2] " Eli Zaretskii
2022-08-03 18:54 ` Tom Tromey
2022-08-03 19:17 ` Eli Zaretskii
2022-08-22 18:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83v8r93zp6.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).