Re: [PATCH 3/3] [gdb/tui] Add set tui contents-highlight on/off

[Eli Zaretskii <eliz@gnu.org>]

> Cc: Tom Tromey <tom@tromey.com>
> Date: Tue, 16 May 2023 10:43:52 +0200
> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
> 
> TUI highlights various parts of TUI windows:
> - highlighting of the current execution point in the assembly and source
>   windows,
> - highlighting of changed registers in the register window.
> 
> Add a new command "set tui contents-highlight on/off" that allows us to disable
> this.
> 
> The default is on, so there's no change in behaviour.
> 
> Note that the highlighting in all three windows is shadowed by the ">" marker,
> so we're not losing information by switching off the highlighting.
> 
> Tested on x86_64-linux.
> ---
>  gdb/doc/gdb.texinfo              |  7 ++++
>  gdb/testsuite/gdb.tui/source.exp | 59 ++++++++++++++++++++++++++++++++
>  gdb/tui/tui-regs.c               |  4 +--
>  gdb/tui/tui-regs.h               |  4 +--
>  gdb/tui/tui-win.c                | 39 +++++++++++++++++++++
>  gdb/tui/tui-win.h                |  4 +++
>  gdb/tui/tui-winsource.c          |  4 +--
>  7 files changed, 115 insertions(+), 6 deletions(-)
>  create mode 100644 gdb/testsuite/gdb.tui/source.exp

The documentation part is OK, thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>