Re: [PATCH 1/2] Introduce gdb.ValuePrinter

[Eli Zaretskii <eliz@gnu.org>]

> Date: Mon, 11 Sep 2023 11:28:25 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> 
> There was an earlier thread about adding new methods to
> pretty-printers:

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 98ff00d5efc..cca86d82de8 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -286,6 +286,11 @@ info main
>       might be array- or string-like, even if they do not have the
>       corresponding type code.
>  
> +  ** gdb.ValuePrinter is a new class that can be used as the base
> +     class for the result of applying a pretty-printer.  As a base
> +     class, it signals to gdb that the printer may implement new
> +     pretty-printer methods.
> +
>  *** Changes in GDB 13

This part is OK.

> +To allow extensibility, @value{GDBN} provides the
> +@code{gdb.ValuePrinter} base class.  This class does not provide any
> +attributes or behavior, but instead serves as a tag that can be
> +recognized by @value{GDBN}.  For such printers, @value{GDBN} reserves
> +all attributes of starting with a lower-case letter.  That is, in the

I think that "of" should be removed.

The python.texi part is OK otherwise.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>