From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation
Date: Tue, 04 Apr 2023 14:36:22 +0300 [thread overview]
Message-ID: <83y1n7ubex.fsf@gnu.org> (raw)
In-Reply-To: <3cdddabce2d5acfbdb9a8c5bdcb1a205a2bd01e5.1680596378.git.aburgess@redhat.com> (message from Andrew Burgess via Gdb-patches on Tue, 4 Apr 2023 09:21:03 +0100)
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Tue, 4 Apr 2023 09:21:03 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
>
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -6909,7 +6909,7 @@
> @code{RuntimeError} exception if it is invalid.
> @end defun
>
> -@defun DisassembleInfo.__init__ (info)
> +@defun DisassembleInfo.__init__ (@var{info})
You consistently rewrite the Texinfo source to use @var inside the
argument lists of a @defun. I already asked why, as I don't think
this is required. I don't think you replied. So once again: why are
you doing this? what problems happen if you don't?
Otherwise, this is fine. Thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-04-04 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 8:21 [PATCH 0/5] Disassembler Styling And The Python API Andrew Burgess
2023-04-04 8:21 ` [PATCH 1/5] gdb/doc: improve Python Disassembler API documentation Andrew Burgess
2023-04-04 11:36 ` Eli Zaretskii [this message]
2023-04-28 22:49 ` Andrew Burgess
2023-05-12 17:42 ` Andrew Burgess
2023-04-04 8:21 ` [PATCH 2/5] gdb/python: implement __repr__ methods for py-disasm.c types Andrew Burgess
2023-05-12 17:43 ` Andrew Burgess
2023-04-04 8:21 ` [PATCH 3/5] gdb/python: implement DisassemblerResult.__str__ method Andrew Burgess
2023-05-12 17:43 ` Andrew Burgess
2023-04-04 8:21 ` [PATCH 4/5] gdb/python: rework how the disassembler API reads the result object Andrew Burgess
2023-04-04 11:38 ` Eli Zaretskii
2023-04-04 8:21 ` [PATCH 5/5] gdb/python: extend the Python Disassembler API to allow for styling Andrew Burgess
2023-04-04 12:01 ` Eli Zaretskii
2023-04-28 23:11 ` Andrew Burgess
2023-04-17 16:25 ` Tom Tromey
2023-04-28 23:09 ` [PATCHv2 " Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1n7ubex.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).