From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 5/5] Handle non-ASCII identifiers in Ada
Date: Mon, 28 Feb 2022 20:59:59 +0200 [thread overview]
Message-ID: <83y21ulsuo.fsf@gnu.org> (raw)
In-Reply-To: <20220228183304.1162089-6-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Mon, 28 Feb 2022 11:33:04 -0700)
> Date: Mon, 28 Feb 2022 11:33:04 -0700
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
>
> +for c in range(0, 0x10FFFF):
> + process_codepoint(c)
This script assumes that the version of Python which will run it is
up-to-date with the latest Unicode Character Database (UCD), right?
Is that a good assumption? Wouldn't it be better to process the UCD
from the latest Unicode Standard directly?
> +@kindex set ada source-charset
> +Set the source character set for Ada. The character set must be one
> +of the ones supported by GNAT. Because this setting affects the
"must be one of the ones supported" sounds awkward. Can you reword
it?
Other than that, the documentation parts are okay. Thanks.
next prev parent reply other threads:[~2022-02-28 19:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 18:32 [PATCH 0/5] " Tom Tromey
2022-02-28 18:33 ` [PATCH 1/5] Simplify a regular expression in ada-lex.l Tom Tromey
2022-02-28 18:33 ` [PATCH 2/5] Don't pre-size result string in ada_decode Tom Tromey
2022-02-28 18:33 ` [PATCH 3/5] Let phex and phex_nz handle sizeof_l==1 Tom Tromey
2022-03-01 14:26 ` Simon Marchi
2022-03-01 14:32 ` Tom Tromey
2022-02-28 18:33 ` [PATCH 4/5] Define HOST_UTF32 in charset.h Tom Tromey
2022-02-28 18:33 ` [PATCH 5/5] Handle non-ASCII identifiers in Ada Tom Tromey
2022-02-28 18:59 ` Eli Zaretskii [this message]
2022-02-28 20:59 ` Tom Tromey
2022-03-01 3:28 ` Eli Zaretskii
2022-03-01 14:49 ` Tom Tromey
2022-03-01 15:17 ` Eli Zaretskii
2022-03-01 15:33 ` Tom Tromey
2022-03-07 14:52 ` [PATCH 0/5] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y21ulsuo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).