Re: [PATCH] gdb/python: test exception case for gdb.solib_name

[Eli Zaretskii <eliz@gnu.org>]

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: Andrew Burgess <aburgess@redhat.com>
> Date: Fri, 15 Mar 2024 11:47:45 +0000
> 
> I noticed that gdb.solib_name() and Progspace.solib_name() were not
> documented as being able to throw an exception, but in some cases it
> is possible to get an exception from these functions.  An exception
> can occur when the address argument can't be converted to an unsigned
> integer.
> 
> This commit extends the documentation to mention the exception case,
> and I've added a couple of tests to cover this case.

Thanks.

> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -521,7 +521,11 @@
>  
>  @defun gdb.solib_name (address)
>  Return the name of the shared library holding the given @var{address}
> -as a string, or @code{None}.  This is identical to
> +as a string, or @code{None} if there is no library containing
> +@var{address}.  If @var{address} can't be converted to a unsigned
                                                          ^^^^^^^^^^
"an unsigned"

> +integer address then an exception will be raised.

Btw, what does it mean for ADDRESS to not be convertible to an
unsigned integer address?  Does it mean ADDRESS is not an integral
number or something?  Maybe we should say that explicitly.

>  @defun Progspace.solib_name (address)
>  Return the name of the shared library holding the given @var{address}
> -as a string, or @code{None}.
> +as a string, or @code{None} if there is no library containing
> +@var{address}.  If @var{address} can't be converted to a unsigned
> +integer address then an exception will be raised.

Same here.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>