From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/python: test exception case for gdb.solib_name
Date: Fri, 15 Mar 2024 07:16:15 -0600 [thread overview]
Message-ID: <87msqzk540.fsf@tromey.com> (raw)
In-Reply-To: <856ee4315d2d615388efe8352b29379feefa4054.1710503245.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 15 Mar 2024 11:47:45 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> I noticed that gdb.solib_name() and Progspace.solib_name() were not
Andrew> documented as being able to throw an exception, but in some cases it
Andrew> is possible to get an exception from these functions. An exception
Andrew> can occur when the address argument can't be converted to an unsigned
Andrew> integer.
Andrew> This commit extends the documentation to mention the exception case,
Andrew> and I've added a couple of tests to cover this case.
Maybe the Basic Python node should have a note explaining that there's a
general rule allowing for type errors and the like.
Tom
next prev parent reply other threads:[~2024-03-15 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 11:47 Andrew Burgess
2024-03-15 12:39 ` Eli Zaretskii
2024-03-15 13:16 ` Tom Tromey [this message]
2024-03-19 9:38 ` Andrew Burgess
2024-03-19 15:55 ` Tom Tromey
2024-03-19 16:04 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msqzk540.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).