From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Export "finish" return value to Python
Date: Mon, 12 Feb 2024 21:24:01 +0200 [thread overview]
Message-ID: <86jzn9qyem.fsf@gnu.org> (raw)
In-Reply-To: <20240212-dap-finish-v1-1-8e30870e8b25@adacore.com> (message from Tom Tromey on Mon, 12 Feb 2024 11:47:02 -0700)
> From: Tom Tromey <tromey@adacore.com>
> Date: Mon, 12 Feb 2024 11:47:02 -0700
>
> This patch changes the Python "stop" event emission code to also add
> the function return value, if it is known. This happens when the stop
> comes from a "finish" command and when the value can be fetched.
>
> The test is in the next patch.
> ---
> gdb/doc/python.texi | 6 ++++++
> gdb/infcmd.c | 17 -----------------
> gdb/python/py-stopevent.c | 23 ++++++++++++++++++++++-
> gdb/thread-fsm.h | 19 +++++++++++++++++++
> 4 files changed, 47 insertions(+), 18 deletions(-)
Thanks, the documentation part is okay.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2024-02-12 19:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-12 18:47 [PATCH 0/2] Add "finish" return value to DAP Tom Tromey
2024-02-12 18:47 ` [PATCH 1/2] Export "finish" return value to Python Tom Tromey
2024-02-12 19:24 ` Eli Zaretskii [this message]
2024-02-12 18:47 ` [PATCH 2/2] Add return value to DAP scope Tom Tromey
2024-02-13 15:01 ` Kévin Le Gouguec
2024-02-13 16:51 ` Tom Tromey
2024-02-13 22:16 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86jzn9qyem.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).