Re: [PATCH 2/2] Add return value to DAP scope

["Kévin Le Gouguec" <legouguec@adacore.com>]

Tom Tromey <tromey@adacore.com> writes:

>>>>>> "Kévin" == Kévin Le Gouguec <legouguec@adacore.com> writes:
>
>>> +    def fetch_one_child(self, idx):
>>> +        global _last_return_value
>>> +        if _last_return_value is not None:
>>> +            if idx == 0:
>>> +                return ("(return)", _last_return_value)
>>> +            idx = idx - 1
>>> +        return super().fetch_one_child(idx)
>
> Kévin> If scopes are cleared whenever the inferior is resumed (my paraphrasing
> Kévin> of § Lifetime of Objects References), can this method be called after
> Kévin> _last_return_value has been reset to None?
>
> Kévin> Wondering if the outer 'if' is necessary, since we only create a
> Kévin> _FinishScopeReference when _last_return_value is not None:
>
> Ah yeah -- that 'if' is a leftover from an earlier iteration.  Thanks.

Pleasure's mine - v2 looks A-OK 👌

> Kévin> Tangentially, wondering if capturing _last_return_value as a
> Kévin> _FinishScopeReference.__init__ parameter would make sense.
>
> It doesn't really matter, because all these objects are only valid
> during a single stop.

Fair; plus I guess adding an attribute would add a second source of
truth, so not a win overall.