From: Eli Zaretskii <eliz@gnu.org>
To: Alex Chronopoulos <achronop@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3] Change message when reaching end of reverse history.
Date: Mon, 15 Apr 2024 13:59:14 +0300 [thread overview]
Message-ID: <86v84ilwn1.fsf@gnu.org> (raw)
In-Reply-To: <20240414193653.3289837-1-achronop@gmail.com> (message from Alex Chronopoulos on Sun, 14 Apr 2024 21:36:53 +0200)
> From: Alex Chronopoulos <achronop@gmail.com>
> Cc: Alex Chronopoulos <achronop@gmail.com>
> Date: Sun, 14 Apr 2024 21:36:53 +0200
>
> In a record session, when we move backward, GDB switches from normal
> execution to simulation. Moving forward again, the emulation continues
> until the end of the reverse history. When the end is reached, the
> execution stops, and a warning message is shown. This message has been
> modified to indicate that the forward emulation has reached the end, but
> the execution can continue as normal, and the recording will also continue.
>
> Before this patch, the warning message shown in that case was the same as
> in the reverse case. This meant that when the end of history was reached in
> either backward or forward emulation, the same message was displayed:
>
> "No more reverse-execution history."
>
> This message remains for backward emulation. However, in forward emulation,
> it has been modified to:
>
> "End of recorded history; following steps will be added to history."
>
> The reason for this change is that the initial message was deceiving, for
> the forward case, making the user believe that forward debugging could not
> continue.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224
> ---
> gdb/NEWS | 5 ++++
> gdb/infrun.c | 8 ++++-
> gdb/testsuite/gdb.btrace/non-stop.exp | 30 ++++++++++++-------
> gdb/testsuite/gdb.reverse/break-precsave.exp | 4 +--
> gdb/testsuite/gdb.reverse/break-reverse.exp | 2 +-
> .../gdb.reverse/machinestate-precsave.exp | 2 +-
> 6 files changed, 36 insertions(+), 15 deletions(-)
Thanks, the NEWS part is approved.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2024-04-15 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-14 19:36 Alex Chronopoulos
2024-04-15 10:59 ` Eli Zaretskii [this message]
2024-04-23 13:33 ` Guinevere Larsen
2024-04-23 14:03 ` Metzger, Markus T
2024-04-23 17:22 ` Guinevere Larsen
2024-04-23 19:36 ` Pedro Alves
2024-05-03 17:16 ` Alex Chronopoulos
2024-05-06 5:19 ` Metzger, Markus T
2024-05-06 14:50 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86v84ilwn1.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=achronop@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).