Re: [PATCH] gdb: add trailing '/' when using 'complete' with directory names

[Tom Tromey <tom@tromey.com>]

>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> This patch contains work pulled from this previously proposed patch:
Andrew>   https://inbox.sourceware.org/gdb-patches/20210213220752.32581-2-lsix@lancelotsix.com/
Andrew> But has been modified by me.  Credit for the original idea and
Andrew> implementation goes to Lancelot, any bugs in this new iteration belong
Andrew> to me.

Thanks for doing this.

Andrew>   (gdb) complete file /tmp/f
Andrew>   file /tmp/foo

This is:

https://sourceware.org/bugzilla/show_bug.cgi?id=16265

Andrew> +	      gdb::unique_xmalloc_ptr<char> tmp
Andrew> +		(static_cast<char *> (xmalloc (strlen (p_rl.get ()) + 2)));
Andrew> +	      char *next = stpcpy (tmp.get (), p_rl.get ());
Andrew> +	      strcpy (next, "/");
Andrew> +	      p_rl = std::move (tmp);

Personally I'd just use 'concat' here.

Andrew> -  completion_tracker ();
Andrew> +  completion_tracker (bool from_readline);

I stick 'explicit' on these out of habit.
 
Andrew> +  /* Tells if the completion task is triggered by readline.
Andrew> +     See m_from_readline.  */
Andrew> +  const bool &from_readline () const

Returning a reference here seems weird.

Other than these little nits it looks fine to me.

Tom