From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>,
Lancelot SIX <lsix@lancelotsix.com>
Subject: Re: [PATCHv3] gdb: add trailing '/' when using 'complete' with directory names
Date: Thu, 11 Jan 2024 10:18:20 -0700 [thread overview]
Message-ID: <87ply7rdpf.fsf@tromey.com> (raw)
In-Reply-To: <ff157019adcddb04eda4de76547476eb277423fd.1704988744.git.aburgess@redhat.com> (Andrew Burgess's message of "Thu, 11 Jan 2024 16:02:32 +0000")
>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
Andrew> In V3:
Andrew> - Add link to bug Tom pointed out,
Andrew> - Use concat rather than temporary std::string. Save a strdup call,
Andrew> - Added 'explicit' to the constructor,
Andrew> - Remove weird 'const reference' thing.
Looks good to me. Thank you for doing this.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-01-11 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 17:20 [PATCH] " Andrew Burgess
2024-01-03 20:16 ` John Baldwin
2024-01-04 12:12 ` [PATCHv2] " Andrew Burgess
2024-01-11 16:02 ` [PATCHv3] " Andrew Burgess
2024-01-11 17:18 ` Tom Tromey [this message]
2024-01-12 11:05 ` Andrew Burgess
2024-01-11 19:25 ` John Baldwin
2024-01-10 18:50 ` [PATCH] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ply7rdpf.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).