From: Andrew Burgess <aburgess@redhat.com>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCHv2 0/3] Changes to error reporting from the expression parser
Date: Thu, 04 Jan 2024 09:43:23 +0000 [thread overview]
Message-ID: <871qaxa0xw.fsf@redhat.com> (raw)
In-Reply-To: <45e7649d-ac6d-47da-ac67-618cf85d2f8d@FreeBSD.org>
John Baldwin <jhb@FreeBSD.org> writes:
> On 1/2/24 6:43 AM, Andrew Burgess wrote:
>> In V2:
>>
>> - Have split the "merging of error handling" into its own patch,
>> adding the new error handling is in its own patch.
>>
>> - Reordered patches, the minor bug fix is now first, follow by the
>> refactor, with the new functionality placed in the last patch.
>>
>> - Have dropped the whole <HERE> marker idea, and gone with the
>> simpler 'error at end of ....' style message. This means that no
>> tests need updating -- I have added a couple of new tests, but
>> everything else should continue to pass as before.
>>
>> ---
>>
>> While working on another patch I wished that the error reporting from
>> the expression parser was better. This series is my attempt to make
>> it better.
>>
>> ---
>>
>> Andrew Burgess (3):
>> gdb: don't try to style content in error calls
>> gdb: merge error handling from different expression parsers
>> gdb: improve error reporting from expression parser
>>
>> gdb/ada-exp.y | 2 +-
>> gdb/c-exp.y | 5 +----
>> gdb/d-exp.y | 5 +----
>> gdb/f-exp.y | 5 +----
>> gdb/go-exp.y | 5 +----
>> gdb/m2-exp.y | 5 +----
>> gdb/p-exp.y | 5 +----
>> gdb/parse.c | 15 +++++++++++++++
>> gdb/parser-defs.h | 9 +++++++++
>> gdb/procfs.c | 6 ++----
>> gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++
>> 11 files changed, 41 insertions(+), 29 deletions(-)
>>
>>
>> base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee
>
> Modulo the one nit I mentioned for the first patch, (and with the
> updated comment you noted in your reply to Lancelot SIX), these both
> look good to me.
>
> Approved-By: John Baldwin <jhb@FreeBSD.org>
I took another look at patch #1, I would have sworn I found two places
originally, but I can't find a second now .... not sure what happened
there.
Anyway, I updated the commit message to talk about a single problem
case, and pushed this series.
Thanks,
Andrew
prev parent reply other threads:[~2024-01-04 9:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 19:56 [PATCH 0/2] " Andrew Burgess
2023-12-23 19:56 ` [PATCH 1/2] gdb: improve error reporting from " Andrew Burgess
2023-12-28 19:12 ` John Baldwin
2023-12-23 19:56 ` [PATCH 2/2] gdb: don't try to style content in error calls Andrew Burgess
2024-01-02 14:43 ` [PATCHv2 0/3] Changes to error reporting from the expression parser Andrew Burgess
2024-01-02 14:43 ` [PATCHv2 1/3] gdb: don't try to style content in error calls Andrew Burgess
2024-01-03 19:50 ` John Baldwin
2024-01-02 14:43 ` [PATCHv2 2/3] gdb: merge error handling from different expression parsers Andrew Burgess
2024-01-02 15:01 ` Lancelot SIX
2024-01-03 9:39 ` Andrew Burgess
2024-01-02 14:43 ` [PATCHv2 3/3] gdb: improve error reporting from expression parser Andrew Burgess
2024-01-03 19:52 ` [PATCHv2 0/3] Changes to error reporting from the " John Baldwin
2024-01-04 9:43 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qaxa0xw.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).