Re: [PATCH] Support DW_TAG_GNU_formal_parameter_pack and DW_TAG_GNU_template_parameter_pack.

[Tom Tromey <tom@tromey.com>]

>>>>> "Ed" == Ed Catmur <ed@catmur.uk> writes:

Hi.  I'm sorry about the long delay on this review.
Unfortunately in gdb you have to send pings for patches.

Ed> https://sourceware.org/bugzilla/show_bug.cgi?id=17272
Ed> Synthesize type and parameter names as T#n, p#n e.g. Args#1, args#1.

Ed> This is a pretty simple approach but it seems to work OK and is
Ed> compatible with the old style type and parameter names emitted by
Ed> old versions of gcc and when it's writing stabs+ format.

Does stabs even handle template parameter packs?

Also are synthesized names really necessary?  If they aren't required in
DWARF perhaps they can just be nullptr.

Ed> -      attr = dwarf2_attr (die,
Ed> +      struct die_info *line_file_die = die;
Ed> +      if (die->tag == DW_TAG_formal_parameter && die->parent && die->parent->tag == DW_TAG_GNU_formal_parameter_pack)

This line looks too long.  There are other minor formatting issues as
well, for example in the GNU style there is usually a space before an
open paren.

Ed> +	  size = snprintf(NULL, 0, "%s#%d", parent_name, ordinal) + 1;
Ed> +	  name = ((char *) obstack_alloc (&cu->per_objfile->per_bfd->obstack, size));
Ed> +	  snprintf(name, size, "%s#%d", parent_name, ordinal);

gdb doesn't generally use snprintf.  There are other options, like
printing to a string and then copying it.

A patch like this needs a test case.

Also I'm curious if this works ok with the Python API.

Tom