Re: [PATCH] Allow strings with printf/eval

[Tom Tromey <tom@tromey.com>]

>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> On 4/24/23 10:12, Tom Tromey wrote:
>>>>>>> "Keith" == Keith Seitz via Gdb-patches <gdb-patches@sourceware.org> writes:
Keith> (gdb) printf "%s\n", "hello"
Keith> evaluation of this expression requires the target program to be active
>> This is https://sourceware.org/bugzilla/show_bug.cgi?id=13098

Keith> Thank you for that bz; I will add a reference in the commit log.

Keith> -  if (value->type ()->code () != TYPE_CODE_PTR
Keith> -      && value->lval () == lval_internalvar
Keith> +  if (((value->type ()->code () != TYPE_CODE_PTR && value->lval () == lval_internalvar)
Keith> +       || (value->type ()->code () == TYPE_CODE_ARRAY && value->lval () == not_lval))
>> I wonder if lval check is necessary here.

Keith> It does not appear to be, but I erred on the overly conservative side when
Keith> implementing the change. Regression testing shows no differences when
Keith> removing that lval check.

Keith> I've removed it locally.

I think with those 2 small changes, the patch is ok.  Thank you.

Tom