Re: [PATCH] gdb/riscv: add systemtap support

[Andrew Burgess <aburgess@redhat.com>]

Tom Tromey <tom@tromey.com> writes:

>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> One thing I wasn't sure about is if the SystemTap support should be
> Andrew> Linux specific, or architecture specific.  For aarch64, arm, ia64, and
> Andrew> ppc, the SystemTap support seems to libe in the ARCH-linux-tdep.c
> Andrew> file, while for amd64, i386, and s390 the implementation lives in
> Andrew> ARCH-tdep.c.  I have no idea which of these is the better choice -- or
> Andrew> maybe both choices are correct in the right circumstances, and I'm
> Andrew> just not aware of how to choose between them.
>
> It's really an ELF feature, but in practice AFAIK it is only used on
> Linux.  Putting it in the arch tdep file seems fine to me, but nothing
> bad will happen if it is in the linux-tdep file.

Thanks for the insight.  I'll move the changes over to riscv-tdep.c and
update the commit message.

Thanks,
Andrew

>
> Andrew> Anyway, for this patch I selected riscv-linux-tdep.c (though clearly,
> Andrew> moving the changes to riscv-tdep.c is trivial if anyone can why that's
> Andrew> a more appropriate location).  It makes sense to me that SystemTap
> Andrew> might be a Linux only tool, which is why I picked the Linux tdep file.
>
> Yeah, they are called SystemTap probes but really they are just
> implemented as a single header file that could be used elsewhere.
>
> Tom