From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb/riscv: add systemtap support
Date: Mon, 20 Mar 2023 07:43:26 -0600 [thread overview]
Message-ID: <87y1nrh729.fsf@tromey.com> (raw)
In-Reply-To: <b063d1818331f944d129e62aff91b22a643679f1.1679300298.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Mon, 20 Mar 2023 08:18:34 +0000")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> One thing I wasn't sure about is if the SystemTap support should be
Andrew> Linux specific, or architecture specific. For aarch64, arm, ia64, and
Andrew> ppc, the SystemTap support seems to libe in the ARCH-linux-tdep.c
Andrew> file, while for amd64, i386, and s390 the implementation lives in
Andrew> ARCH-tdep.c. I have no idea which of these is the better choice -- or
Andrew> maybe both choices are correct in the right circumstances, and I'm
Andrew> just not aware of how to choose between them.
It's really an ELF feature, but in practice AFAIK it is only used on
Linux. Putting it in the arch tdep file seems fine to me, but nothing
bad will happen if it is in the linux-tdep file.
Andrew> Anyway, for this patch I selected riscv-linux-tdep.c (though clearly,
Andrew> moving the changes to riscv-tdep.c is trivial if anyone can why that's
Andrew> a more appropriate location). It makes sense to me that SystemTap
Andrew> might be a Linux only tool, which is why I picked the Linux tdep file.
Yeah, they are called SystemTap probes but really they are just
implemented as a single header file that could be used elsewhere.
Tom
next prev parent reply other threads:[~2023-03-20 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 8:18 Andrew Burgess
2023-03-20 13:43 ` Tom Tromey [this message]
2023-03-20 20:47 ` Andrew Burgess
2023-03-20 21:54 ` [PATCHv2] " Andrew Burgess
2023-03-21 14:15 ` Tom Tromey
2023-03-23 7:20 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1nrh729.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).