From: Tom Tromey <tom@tromey.com>
To: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Aaron Merey <amerey@redhat.com>, tom@tromey.com, keiths@redhat.com
Subject: Re: [PATCH 2/2] gdb/source: Fix open_source_file error handling
Date: Fri, 10 Feb 2023 07:41:06 -0700 [thread overview]
Message-ID: <871qmxzipp.fsf@tromey.com> (raw)
In-Reply-To: <20230210015942.3180401-3-amerey@redhat.com> (Aaron Merey via Gdb-patches's message of "Thu, 9 Feb 2023 20:59:42 -0500")
>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:
Aaron> Fix this by having open_source_file return a negative errno if it fails
Aaron> to open a source file. Use this value to generate the error message
Aaron> instead of errno.
Thanks for doing this.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-02-10 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 1:59 [PATCH v2 0/2] gdb: " Aaron Merey
2023-02-10 1:59 ` [PATCH 1/2] Move implementation of perror_with_name to gdbsupport Aaron Merey
2023-02-10 14:39 ` Tom Tromey
2023-02-11 2:13 ` Aaron Merey
2023-02-10 1:59 ` [PATCH 2/2] gdb/source: Fix open_source_file error handling Aaron Merey
2023-02-10 14:41 ` Tom Tromey [this message]
2023-02-11 2:14 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qmxzipp.fsf@tromey.com \
--to=tom@tromey.com \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).