public inbox for
 help / color / mirror / Atom feed
From: Tom Tromey <>
To: Aaron Merey via Gdb-patches <>
Cc: Aaron Merey <>,,
Subject: Re: [PATCH 1/2] Move implementation of perror_with_name to gdbsupport
Date: Fri, 10 Feb 2023 07:39:14 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Aaron Merey via Gdb-patches's message of "Thu, 9 Feb 2023 20:59:41 -0500")

>>>>> "Aaron" == Aaron Merey via Gdb-patches <> writes:

Aaron> gdbsupport/errors.h declares perror_with_name and leaves the
Aaron> implementation to the clients.

Aaron> However gdb and gdbserver's implementations are essentially the
Aaron> same, resulting in unnecessary code duplication.

Aaron> Fix this by implementing perror_with_name in gdbsupport.  Add an
Aaron> optional parameter for specifying the errno used to generate the
Aaron> error message.

Aaron> Also move the implementation of perror_string to gdbsupport since
Aaron> perror_with_name requires it.

Thanks, this looks great.

Approved-By: Tom Tromey <>


  reply	other threads:[~2023-02-10 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  1:59 [PATCH v2 0/2] gdb: Fix open_source_file error handling Aaron Merey
2023-02-10  1:59 ` [PATCH 1/2] Move implementation of perror_with_name to gdbsupport Aaron Merey
2023-02-10 14:39   ` Tom Tromey [this message]
2023-02-11  2:13     ` Aaron Merey
2023-02-10  1:59 ` [PATCH 2/2] gdb/source: Fix open_source_file error handling Aaron Merey
2023-02-10 14:41   ` Tom Tromey
2023-02-11  2:14     ` Aaron Merey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).