From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX <Lancelot.Six@amd.com>
Cc: Tom Tromey <tom@tromey.com>,
Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>,
lsix@lancelotsix.com
Subject: Re: [PATCH v2 1/2] gdb: Require psymtab before calling quick_functions in objfile
Date: Fri, 20 May 2022 19:07:34 -0600 [thread overview]
Message-ID: <871qwng0bt.fsf@tromey.com> (raw)
In-Reply-To: <0db126be-7d03-d8ec-c825-a8dbd3d4ce72@amd.com> (Lancelot SIX's message of "Sat, 21 May 2022 00:07:06 +0100")
>>>>> "Lancelot" == Lancelot SIX <Lancelot.Six@amd.com> writes:
Lancelot> I have changed the declaration locally as follows (I did some back and
Lancelot> forth on whether it should stay grouped with the other methods of
Lancelot> ojbfile bracketed between a pritave:/public: pair or if it should go
Lancelot> in a private section at the end of the struct — I finally opted for
Lancelot> former).
Yeah, objfile is a bit messy, someday we can try to clean it up. I
think what you did is fine.
Tom
next prev parent reply other threads:[~2022-05-21 1:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 18:45 [PATCH v2 0/2] Fix regression with lazy-loading of partial symbols Lancelot SIX
2022-05-19 18:45 ` [PATCH v2 1/2] gdb: Require psymtab before calling quick_functions in objfile Lancelot SIX
2022-05-20 15:51 ` Tom Tromey
2022-05-20 23:07 ` Lancelot SIX
2022-05-21 1:07 ` Tom Tromey [this message]
2022-05-19 18:45 ` [PATCH v2 2/2] gdb: Simplify psymbol_functions::require_partial_symbols Lancelot SIX
2022-05-20 15:51 ` Tom Tromey
2022-05-20 16:07 ` Simon Marchi
2022-05-20 22:55 ` [PATCH v3 2/2] gdb: Change psymbol_functions::require_partial_symbols to partial_symbols Lancelot SIX
2022-05-26 17:57 ` Tom Tromey
2022-05-26 20:42 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qwng0bt.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).