From: Tom Tromey <tom@tromey.com>
To: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb: prevent the use of the clear command to remove the internal breakpoint (PR cli/7161)
Date: Mon, 14 Mar 2022 07:55:16 -0600 [thread overview]
Message-ID: <871qz4ljuj.fsf@tromey.com> (raw)
In-Reply-To: <MEAP282MB02934158E060B08C8A69930EDD0F9@MEAP282MB0293.AUSP282.PROD.OUTLOOK.COM> (Enze Li via Gdb-patches's message of "Mon, 14 Mar 2022 20:24:06 +0800")
>>>>> Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
> +/* See breakpoint.h. */
> +bool
> +internal_breakpoint (struct breakpoint *b)
> +{
> + return b->ops == &internal_breakpoint_ops;
> +}
I think the correct test is probably if the breakpoint number is <=0.
There are, I think, "internal" breakpoints that don't use
internal_breakpoint_ops.
Tom
prev parent reply other threads:[~2022-03-14 13:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 12:24 Enze Li
2022-03-14 13:53 ` Pedro Alves
2022-03-17 14:30 ` Enze Li
2022-03-14 13:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qz4ljuj.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).