public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Matt Rice <ratmice@gmail.com>, Eli Zaretskii <eliz@gnu.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Show locno for 'multi location' breakpoint hit msg+conv var $bkptno $locno.
Date: Sat, 04 Jun 2022 19:45:53 +0200	[thread overview]
Message-ID: <8731d516b74f787673ac6e2ece5b4f430a09165b.camel@skynet.be> (raw)
In-Reply-To: <CACTLOFre-GhwAe4i+tgq7a1VmCBkm-_HYe7+bdvpxrVW7sbFUw@mail.gmail.com>

On Sat, 2022-06-04 at 17:27 +0000, Matt Rice via Gdb-patches wrote:
> On Sat, Jun 4, 2022 at 6:23 AM Eli Zaretskii via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
> > 
> > > Date: Fri, 3 Jun 2022 13:40:00 -0700
> > > From: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
> > > 
> > > I looked up the history of this patch a bit to understand the motivation
> > > for querying co-workers... I see Eli commented in the original April
> > > discussion:
> > > 
> > > > I'm not sure everyone will want to see the likes of
> > > > 
> > > >  Thread 1 "foobar" hit breakpoint 10.42, some_func () at ...
> > > > 
> > > > But that's MO; I'd be interested in opinions of others.
> > > 
> > > Well, I'm not a global maintainer, but I'll chime in with my opinion,
> > > if everyone will permit me. [Ha! You're already reading it!]
> > > 
> > > I don't think it is a big deal to see ".42" in the output. Far more
> > > irritating is not knowing exactly which of the many locations it hit.
> > > I've always felt this was akin to ambiguous output by GDB. "You hit
> > > breakpoint X." Oh, wait, that's one of fifty different real breakpoints.
> > 
> > We show the source line where the breakpoint breaks right after this,
> > so at least some of the ambiguity is resolved by that.
> 
> My thoughts are that whether or not source line resolving ambiguity
> printing the breakpoint locno
> may be useful for instance, `disable 10.42` to disable that location,
> you wouldn't have to do
> info break and look through the what or address column of `info b`.
Yes, that was the main trigger to add this change.
As you indicate, if the breakpoint is in an inlined function,
then all locations have the same source and line nr
and the only differentiating aspect is then the address.

Philippe





  reply	other threads:[~2022-06-04 17:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-17 15:53 Philippe Waroquiers
2022-04-17 16:14 ` Eli Zaretskii
2022-04-17 16:27   ` Philippe Waroquiers
2022-04-17 17:55     ` Eli Zaretskii
2022-04-29 16:26 ` Philippe Waroquiers
2022-05-07  5:44   ` Philippe Waroquiers
2022-05-13 16:49   ` Philippe Waroquiers
2022-05-22 18:43   ` Philippe Waroquiers
2022-05-30 19:08   ` Philippe Waroquiers
2022-06-03 20:40     ` Keith Seitz
2022-06-04  6:23       ` Eli Zaretskii
2022-06-04 17:27         ` Matt Rice
2022-06-04 17:45           ` Philippe Waroquiers [this message]
2022-06-04 17:37       ` Philippe Waroquiers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8731d516b74f787673ac6e2ece5b4f430a09165b.camel@skynet.be \
    --to=philippe.waroquiers@skynet.be \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ratmice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).