From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tom@tromey.com>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 2/9] gdb: pass frame_info_ptr to gdbarch_value_from_register
Date: Fri, 22 Dec 2023 09:56:24 -0700 [thread overview]
Message-ID: <8734vu18hz.fsf@tromey.com> (raw)
In-Reply-To: <184fe643-5380-41a3-9f92-1eabc6ba61ef@simark.ca> (Simon Marchi's message of "Fri, 22 Dec 2023 11:53:08 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>> FWIW I tend to think new code should use 'const frame_info_ptr &' in
>> most places. It's more efficient and the design of frame_info_ptr also
>> makes it harmless, as the underlying frame_info member is mutable.
Simon> I initially thought that frame_info_ptr would be a thin enough wrapper
Simon> that it would be better to pass it by value, but I see that it's 64
Simon> bytes long, so I guess you're right. I'll change my patches, but we
Simon> should probably change the existing code too.
Yeah, and it also registers/deregisters itself on a global list...
Simon> It will also appease a frustration I had, where passing a frame_info_ptr
Simon> down to a function would call the copy constructor. So, trying to step
Simon> into that function would first step into the frame_info_ptr constructor
Simon> first.
I also find this annoying, though not yet to the point where I'm tempted
to add a gdb feature to make it nicer.
I think we have a bug open about stepping into the "last" function call
on a line, which is pretty much this idea: skip over all the copy
constructors and into the call you really care about. Dunno if this is
even implementable with current debuginfo.
Tom
next prev parent reply other threads:[~2023-12-22 16:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 19:16 [PATCH 0/9] Some register value cleanups Simon Marchi
2023-12-21 19:16 ` [PATCH 1/9] gdb: don't set frame id after calling cooked_read_value Simon Marchi
2023-12-21 19:16 ` [PATCH 2/9] gdb: pass frame_info_ptr to gdbarch_value_from_register Simon Marchi
2023-12-22 16:40 ` Tom Tromey
2023-12-22 16:53 ` Simon Marchi
2023-12-22 16:56 ` Tom Tromey [this message]
2023-12-21 19:16 ` [PATCH 3/9] gdb: pass non-nullptr frame to gdbarch_value_from_register in address_from_register Simon Marchi
2023-12-21 19:16 ` [PATCH 4/9] gdb: add type parameter to value::allocate_register and add value::allocate_register_lazy Simon Marchi
2023-12-21 19:16 ` [PATCH 5/9] gdb: remove read_frame_register_value's frame parameter Simon Marchi
2023-12-21 19:16 ` [PATCH 6/9] gdb: implement address_from_register using value_from_register Simon Marchi
2023-12-21 19:16 ` [PATCH 7/9] gdb: remove VALUE_NEXT_FRAME_ID, add value::next_frame_id Simon Marchi
2023-12-22 16:51 ` Tom Tromey
2023-12-22 16:56 ` Simon Marchi
2023-12-22 17:02 ` Tom Tromey
2023-12-22 17:06 ` Simon Marchi
2023-12-24 15:35 ` Simon Marchi
2023-12-21 19:16 ` [PATCH 8/9] gdb: remove VALUE_REGNUM, add value::regnum Simon Marchi
2023-12-22 16:52 ` Tom Tromey
2023-12-22 16:57 ` Simon Marchi
2023-12-21 19:16 ` [PATCH 9/9] gdb: make value::allocate_register_lazy store id of next non-inline frame Simon Marchi
2023-12-22 16:53 ` [PATCH 0/9] Some register value cleanups Tom Tromey
2023-12-22 16:58 ` Simon Marchi
2023-12-22 17:02 ` Tom Tromey
2023-12-24 18:28 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734vu18hz.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).